Thread/LHN - Parent message is not updated in LHN after editing it in thread conversation

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.45-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6094905
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: MacBook Air 15.4 Crome, iPhone 15 iOS 18.4.1 Safari
App Component: Left Hand Navigation (LHN)

Action Performed:

1. Navigate to staging.new.expensify.com and sign in with gmail account
2. Open any chat and send a message
3. Start a thread on that message, send some messages
4. Edit the parent comment in the threaded conversation
5. Verify that the parent message was updated in the header of the thread and in the LHN

Expected Result:

Parent message is updated in the LHN of the thread conversation after editing it

Actual Result:

Parent message is not updated in LHN after editing it in thread conversation. It gets updated, when user navigates away from the thread and back.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Burhan-Rashid]

It is the duplicate issue @jponikarchuk. We are already having same open issue here. #61900

[Burhan-Rashid]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread/LHN - Parent message is not updated in LHN after editing it in thread conversation

What is the root cause of that problem?

while calculating the title/ReportName/ThreadName of LHN we doesn't take into account the parentReportAction attribute, that is why it shows old title instead of the updated one.

App/src/libs/SidebarUtils.ts

Lines 701 to 704 in 074a9fd

	const reportName = getReportName(report, policy, undefined, undefined, invoiceReceiverPolicy);
	result.text = reportName;

What changes do you think we should make in order to solve the problem?

We need to consider the parentReportAction while calculating the reportName here.

App/src/libs/SidebarUtils.ts

Lines 701 to 704 in 074a9fd

	const reportName = getReportName(report, policy, undefined, undefined, invoiceReceiverPolicy);
	result.text = reportName;

const reportName = getReportName(report, policy, parentReportAction, undefined, invoiceReceiverPolicy);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[jponikarchuk]

@Burhan-Rashid It's a same root issue, thanks

[Christinadobrzyn]

Sounds good - thanks for catching that @Burhan-Rashid - closing in favor of #61900