-
Notifications
You must be signed in to change notification settings - Fork 3.2k
WS chat - Pay button briefly appears before approve button. #61673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @joekaufmanexpensify ( |
@linhvovan29546 @rojiphil @youssef-lr Is this related to your PR #61355? |
I don't think this is a huge deal, as the correct button to approve does show up quickly. But if we introduced it there, would be good to quickly fix. |
In production, the Pay button appears briefly, but the Approve button doesn’t show. After the above PR, the Approve button is now displayed. I believe I’ve known the root cause. |
Got it. So you're saying the pay button was appearing briefly before your PR? |
Production behavior Screen.Recording.2025-05-08.at.21.20.38.mov |
I think the root cause is similar, but I'm not sure if the solution will be the same as in the PR above. |
Got it. I tested it on staging though and it is still happening. |
@joekaufmanexpensify The issue related to This issue is already in production as mentioned in OP. And, I think the QA identified this issue while testing the PR. As the root cause and the implementation of this issue is different, we can open up for proposals if this needs a fix. |
I just checked using the new table feature and didn’t observe the briefly. |
Got it, thanks for the explanation! Personally, I am not super passionate about changing this right now. Infinite sessions make it unlikely someone will experience this. Further, even if they do, it's not super noticeable unless you're specifically looking for it, and we very quickly show the correct button. |
Closing this for now. Let's revisit if we get feedback on it from customers. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.42-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #61355
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: mweb
App Component: Chat Report View
Action Performed:
Preconditions:
Use Gmail Account
User A is an approver.
User B is a member.
The workspace has both Manual Delay Submission and Approver workflows enabled.
Expected Result:
The Pay button should not be visible
Actual Result:
Pay button briefly appears on first time expense page load
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6825321_1746691668423.1.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: