Skip to content

WS chat - Pay button briefly appears before approve button. #61673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 8 tasks
mitarachim opened this issue May 8, 2025 · 12 comments
Closed
1 of 8 tasks

WS chat - Pay button briefly appears before approve button. #61673

mitarachim opened this issue May 8, 2025 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.42-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #61355
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: mweb
App Component: Chat Report View

Action Performed:

Preconditions:
Use Gmail Account
User A is an approver.
User B is a member.
The workspace has both Manual Delay Submission and Approver workflows enabled.

  1. Go to https://staging.new.expensify.com/
  2. User B creates an expense in the WS chat and submits it.
  3. User A signs out and signs back in
  4. User A opens the expense that was just submitted.

Expected Result:

The Pay button should not be visible

Actual Result:

Pay button briefly appears on first time expense page load

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6825321_1746691668423.1.mp4

View all open jobs on GitHub

@mitarachim mitarachim added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 8, 2025
Copy link

melvin-bot bot commented May 8, 2025

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@joekaufmanexpensify
Copy link
Contributor

@linhvovan29546 @rojiphil @youssef-lr Is this related to your PR #61355?

@joekaufmanexpensify
Copy link
Contributor

I don't think this is a huge deal, as the correct button to approve does show up quickly. But if we introduced it there, would be good to quickly fix.

@linhvovan29546
Copy link
Contributor

In production, the Pay button appears briefly, but the Approve button doesn’t show. After the above PR, the Approve button is now displayed. I believe I’ve known the root cause.

@joekaufmanexpensify
Copy link
Contributor

Got it. So you're saying the pay button was appearing briefly before your PR?

@linhvovan29546
Copy link
Contributor

Production behavior

Screen.Recording.2025-05-08.at.21.20.38.mov

@linhvovan29546
Copy link
Contributor

I think the root cause is similar, but I'm not sure if the solution will be the same as in the PR above.

@joekaufmanexpensify
Copy link
Contributor

Got it. I tested it on staging though and it is still happening.

@rojiphil
Copy link
Contributor

rojiphil commented May 8, 2025

I don't think this is a huge deal, as the correct button to approve does show up quickly. But if we introduced it there, would be good to quickly fix.

@joekaufmanexpensify The issue related to pay button is different than what we fixed in the PR. The PR fixed the issue where the approve button was not displayed.

This issue is already in production as mentioned in OP. And, I think the QA identified this issue while testing the PR.

As the root cause and the implementation of this issue is different, we can open up for proposals if this needs a fix.

@linhvovan29546
Copy link
Contributor

I just checked using the new table feature and didn’t observe the briefly.

@joekaufmanexpensify
Copy link
Contributor

Got it, thanks for the explanation! Personally, I am not super passionate about changing this right now. Infinite sessions make it unlikely someone will experience this. Further, even if they do, it's not super noticeable unless you're specifically looking for it, and we very quickly show the correct button.

@joekaufmanexpensify
Copy link
Contributor

Closing this for now. Let's revisit if we get feedback on it from customers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants