[Due for payment 2025-05-27] Show settlement account for admins who don't own bank account

[puneetlath]

Part of the Cross Compatible Corporate Cards project

Main issue: https://github.com/Expensify/Expensify/issues/467915

Feature Description

Right now, if you are an admin on a workspace, but not shared on the bank account used for Expensify Card settlement, you see a blank page when you view the settlement account settings.

This is true whether you are a workspace admin looking at a workspace feed's settings or a domain admin looking at a domain feed's settings. To fix this, I have updated the back-end to return paymentBankAccountAddressName and paymentBankAccountNumber in addition to paymentBankAccountID in the card settings object.

Let's update the client to use these, when the user doesn't have the bank account in their bankAccountsList. That way we can still display in the card settings which settlement account is being used.

Manual Test Steps

1. Set up an accountOwner with a policyA and policyB
2. invite accountAdmin to both policies as an admin
3. set up accountOwner with a bank account and enable the Expensify Card on policyA
4. set up a domain Expensify Card feed on the domain and set its preferred policy as policyB
5. go to the workspace settings of policyA as accountAdmin
6. you should be able to see the settlement account for the Expensify Cards
7. go to the workspace settings of policyB as accountAdmin
8. you should be able to see the settlement account for the Expensify Cards

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[puneetlath]

@koko57 @VickyStash @DylanDylann would one of y'all want to take this? The back-end PR is in review, so will probably go live tomorrow or the day after. But you should be able to start on it with mock data in the meantime.

[DylanDylann]

Ideally, @koko57 or @VickyStash will create the PR, and I’ll assist with the review. If neither is available, I’ll go ahead and create the PR myself.

[waterim]

Hello, Im Artem from Callstack and will help with this one

[puneetlath]

Great. Assigned you @waterim

[puneetlath]

How's it going @waterim?

[waterim]

Started today!

[Christinadobrzyn]

Just a heads up that I'm going to be ooo May 21st - May 27th. Back on the 28th.

I'm not going to assign another BZ teammate but if you need someone while I'm gone, please remove and add the Bug label.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Feat: Show settlement account for admins who don't own bank account #61880

If no regressions arise, payment will be issued on 2025-05-27. 🎊

For reference, here are some details about the assignees on this issue:

• @waterim does not require payment (Contractor)
• @DylanDylann requires payment through NewDot Manual Requests

[melvin-bot]

@DylanDylann @Christinadobrzyn @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]