[$250] Reports - Expense report opens when individual expense row is clicked

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.39-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

Precondition:

• Account has self DM.

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Track a manual expense in self DM.
4. Click Share it with my accountant from actionable whisper.
5. Click New workspace if account has existing workspace.
6. Enter merchant and click Create expense.
7. On workspace chat, submit another expense via + menu.
8. Click Submit on the expense preview.
9. Go to Reports.
10. Click one of the expenses.

Expected Result:

The transaction thread of the selected expense will open.

Actual Result:

The expense report opens instead, when the individual expense is clicked.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6819407_1746180003933.20250502_175351.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021918344113541720120
• Upwork Job ID: 1918344113541720120
• Last Price Increase: 2025-05-02

Issue Owner

Current Issue Owner: @c3024

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021918344113541720120

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[sakluger]

I will be OOO from May 5 - 16, so I have added another BZ member to watch over the issue while I'm out.

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The expense report opens instead, when the individual expense is clicked.

What is the root cause of that problem?

• The report is opened using a reportID derived here::
  

  App/src/components/Search/index.tsx

  Lines 367 to 370 in 017630a

  	let reportID =
  	isTransactionItem && (!item.isFromOneTransactionReport || isFromSelfDM) && item.transactionThreadReportID !== CONST.REPORT.UNREPORTED_REPORT_ID
  	? item.transactionThreadReportID
  	: item.reportID;

• Two reports share the same reportID and have isFromOneTransactionReport=true (a backend bug, maybe). This causes conflicts, as both reports resolve to the same ID.

What changes do you think we should make in order to solve the problem?

• Remove the item.isFromOneTransactionReport condition, as transactionThreadReportID is guaranteed to be unique. This aligns with existing logic for openReportInRHP in Expense Reports:

let reportID =
    isTransactionItem && item.transactionThreadReportID !== CONST.REPORT.UNREPORTED_REPORT_ID
        ? item.transactionThreadReportID
        : item.reportID;

App/src/components/SelectionList/Search/ReportListItem.tsx

Lines 101 to 105 in ec1a8cd

	const openReportInRHP = (transactionItem: TransactionListItemType) => {
	const backTo = Navigation.getActiveRoute();
	Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute({reportID: transactionItem.transactionThreadReportID, backTo}));
	};

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[c3024]

That check was specifically added in this PR to fix some issues. Removing it can bring them back. I think we should fix this from backend.

[c3024]

@sakluger @RachCHopkins

This needs a fix from the backend. This needs to be internal.

[melvin-bot]

@c3024 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@c3024 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@sakluger @RachCHopkins @c3024 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[sakluger]

I just got back from OOO - I'm going to move this to weekly while I figure out prioritization and work on recruiting an engineer to fix it.

[melvin-bot]

@c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!