[Due for payment 2025-05-14] Reports-"Oops something went wrong" is displayed when navigating through contextual filters

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.39.1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6033034
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: iPhone 15 iOS 18.4.1 Safari, MacBook Air 15.4 Chrome
App Component: Search

Action Performed:

1. Navigate to the staging.new.expensify.com and sign in with gmail account, that has some expenses and chats
2. Navigate to the Reports tab/ Expenses
3. Tap the "Outstanding", then "All" tabs on Hybrid app and mWeb, navigate through the contextual filters in Expenses on Desktop.
4. In Reports tab open Chats and navigate through All, Unread, Drafts, Sent, Attachments and Links contextual filters.

Expected Result:

User is navigating through the contextual filters in Expenses and Chats without any errors

Actual Result:

"Uh-oh, something went wrong" is displayed when the user navigates through the different contextual filters in the Expenses and Chats tabs in Reports

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6818999_1746140797605.Recording__212.mp4

Bug6818999_1746138285372!Reports_Console.txt

Bug6818999_1746138285370.Error.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @alitoshmatov

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021919853669528528861
• Upwork Job ID: 1919853669528528861
• Last Price Increase: 2025-05-06
• Automatic offers:
• nkdengineer | Contributor | 107204027

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[marcaaron]

Seems to be throwing here:

App/src/components/Search/SearchList.tsx

Line 204 in f7c1995

listRef.current.scrollToIndex({index, animated, viewOffset: variables.contentHeaderHeight});

hook.js:608 Invariant Violation: scrollToIndex should be used in conjunction with getItemLayout or onScrollToIndexFailed, otherwise there is no way to know the location of offscreen indices or handle failures.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-02 04:01:17 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Uh-oh, something went wrong" is displayed when the user navigates through the different contextual filters in the Expenses and Chats tabs in Reports

What is the root cause of that problem?

When switching between tabs, we trigger this logic:

App/src/components/Search/SearchList.tsx

Line 204 in f7c1995

listRef.current.scrollToIndex({index, animated, viewOffset: variables.contentHeaderHeight});

and then it throw error

hook.js:608 Invariant Violation: scrollToIndex should be used in conjunction with getItemLayout or onScrollToIndexFailed, otherwise there is no way to know the location of offscreen indices or handle failures.

I think we're calling scrollToIndex too early, and if we scroll to an index which has not been rendered, then the error will show.

What changes do you think we should make in order to solve the problem?

We have some solutions:

1. Run scrollToIndex in runAfterInteractions

InteractionManager.runAfterInteractions(()=>{
                listRef.current?.scrollToIndex({index, animated, viewOffset: variables.contentHeaderHeight});
            })

2. We can use onScrollToIndexFailed with some delays, for example

onScrollToIndexFailed={info => {
                    const wait = new Promise(resolve => setTimeout(resolve, 500));
                    wait.then(() => {
                        listRef.current?.scrollToIndex({index: info.index, animated: true});
                    });
                  }}

3. We can call handleSelectionListScroll in onLayout

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[marcaaron]

What caused it?

[nkdengineer]

@marcaaron I think it comes from this PR: https://github.com/Expensify/App/pull/60896/files#diff-c44d60a3d1d1595550c8cf81507ae43b596ac81c528c4c6bf970ef71d6bb6a84L184

[nkdengineer]

We should trigger scroll in inLayout like we did in

App/src/components/SelectionList/BaseSelectionList.tsx

Lines 685 to 691 in 223a34c

	const onSectionListLayout = useCallback(
	(nativeEvent: LayoutChangeEvent) => {
	onLayout?.(nativeEvent);
	scrollToFocusedIndexOnFirstRender(nativeEvent);
	},
	[onLayout, scrollToFocusedIndexOnFirstRender],
	);

[marcaaron]

@martasudol @mountiny can you all chime in on the above. If it is related to that PR we should give them a change to fix it? I don't think we are in a rush to deploy on Friday.

[danieldoglas]

Removing DeployBlocker tag since doesn't look to be related to backend issues.

[marcaaron]

We should probably fix this (vs. revert) since it seems relatively easy to suppress this warning for now or fix it with @nkdengineer's changes. Asking in the Slack thread to see if there are any strong feelings one way vs. another.

[nkdengineer]

@marcaaron I think we should call handleSelectionListScroll in onLayout, because onLayout is trigger when items are rendered. Can I work on the PR?

[marcaaron]

Yeah I think that's fine. I haven't heard back from the PR authors/reviewers so let's do it.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021919853669528528861

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[marcaaron]

@RachCHopkins for context, I removed the Awaiting Payment label as we hot fixed this issue to unblock deploy, but the proper fix will be done by @nkdengineer

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.40-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Noop for onScrollToIndexFailed #61392

If no regressions arise, payment will be issued on 2025-05-14. 🎊

For reference, here are some details about the assignees on this issue:

• @alitoshmatov requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@alitoshmatov @RachCHopkins @alitoshmatov The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[alitoshmatov]

Please unassign me, I didn't participate in this issue.