Skip to content

[Due for payment 2025-05-22] [Better Expense Report View] Improve TransactionPreview viewability #61161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trjExpensify opened this issue Apr 30, 2025 · 6 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@trjExpensify
Copy link
Contributor

trjExpensify commented Apr 30, 2025

Problem: Currently, when screen is in wide setting, the TransactionPreview's width is constant at 303px, but it is possible for available space to be less than that - that disturbs the comfortable use of the Carousel and readability of the expenses. It might also lead to navigation issues.

before

Solution: make the TransactionPreview's width adaptable to narrowing screen's width, when it is too small to fit default 303px version. In described scenario, also X expenses is hidden to enhance report's title readability, but is still visible when TransactionPreview's width reaches default

after
Issue OwnerCurrent Issue Owner: @trjExpensify
@trjExpensify trjExpensify added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Apr 30, 2025
@trjExpensify trjExpensify moved this to Second Cohort - CRITICAL in [#whatsnext] #migrate Apr 30, 2025
Copy link

melvin-bot bot commented Apr 30, 2025

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 30, 2025
@trjExpensify trjExpensify moved this from Second Cohort - CRITICAL to Second Cohort - HIGH in [#whatsnext] #migrate May 9, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 12, 2025
Copy link

melvin-bot bot commented May 13, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented May 14, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 15, 2025
@melvin-bot melvin-bot bot changed the title [Better Expense Report View] Improve TransactionPreview viewability [Due for payment 2025-05-22] [Better Expense Report View] Improve TransactionPreview viewability May 15, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 15, 2025
Copy link

melvin-bot bot commented May 15, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 15, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-22. 🎊

For reference, here are some details about the assignees on this issue:

  • @Guccio163 does not require payment (Contractor)
  • @allgandalf requires payment (Needs manual offer from BZ)
  • @DylanDylann requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented May 15, 2025

@allgandalf / @DylanDylann @trjExpensify @allgandalf / @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
Status: Second Cohort - HIGH
Development

No branches or pull requests

5 participants