[Due for payment 2025-05-22] [Due for payment 2025-05-13] [$250] Reducing Search API Calls in Reports Screen

[mountiny]

Coming from this proposal.

Background:

When users open an expense report from the "Reports" tab, the application displays the detailed report information. Currently, the useSearchHighlightAndScroll hook is doing more than what its name suggests - beyond just handling UI highlighting and scrolling functions, it's also making API calls to the /Search endpoint. Hooks should ideally have single responsibilities that match their names, but this hook is currently performing data fetching operations that lie outside its intended purpose.

Problem:

When a user opens an expense report, multiple redundant calls to the /Search endpoint are triggered (by useSearchHighlightAndScroll hook), wasting network resources and impacting application performance.

Solution:
We will separate the concerns by:

1. Refining useSearchHighlightAndScroll to handle only UI tasks (highlighting and scrolling)
2. Creating a new useSearchPusherUpdates hook in Search/index.tsx to handle Pusher update events and make /Search API calls only when necessary

This separation will maintain functionality while reducing network overhead and improving performance.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021917145585218173680
• Upwork Job ID: 1917145585218173680
• Last Price Increase: 2025-04-29

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021917145585218173680

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[melvin-bot]

Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ishakakkad]

Solution is already defined in OP, I would like to work on this task if this will be done by external.

[mountiny]

Thanks! Callstack will handle this

[mountiny]

@martasudol lets please handle this one in one more PR #60896 (comment)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[c3024]

PR reverted. New PR to be opened.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @martasudol is from an agency-contributor and not due payment
• Reviewer: @c3024 owed $250 via NewDot

BugZero Checklist (@Christinadobrzyn)

• I have verified the correct assignees and roles are listed above and updated the necessary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1917145585218173680/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[c3024]

@Christinadobrzyn , yes, that's correct!

[Christinadobrzyn]

watching PR - #61499

[Christinadobrzyn]

watching PR - #61499

Gonna move this back to weekly since the PR will still need to go through the 7 day window

[mountiny]

Had to be reverted due to blocker unfortunately

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: get rid of redundant /Search API calls when opening report in RHN #61499

If no regressions arise, payment will be issued on 2025-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @martasudol does not require payment (Contractor)
• @c3024 requires $250 payment through NewDot Manual Requests

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Christinadobrzyn]

Just a heads up that I'm going to be ooo May 21st - May 27th. Back on the 28th.

I'll assign someone to pay this.

@c3024 do we need a regression test for this?

cc @JmillsExpensify

[c3024]

The PR was reverted, so payment is not yet due.

[martasudol]

New PR created here.