Skip to content

[Due for payment 2025-05-20] Report - Pay button overlaps avatar #61037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
jponikarchuk opened this issue Apr 29, 2025 · 20 comments
Closed
2 of 8 tasks

[Due for payment 2025-05-20] Report - Pay button overlaps avatar #61037

jponikarchuk opened this issue Apr 29, 2025 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@jponikarchuk
Copy link

jponikarchuk commented Apr 29, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.33-3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): -
Issue reported by: Applause Internal Team
Device used: MacOS Big Sur
App Component: Chat Report View

Action Performed:

Precondition: Create expense in ws chat. Submit and approve it.

  1. Go to report details
  2. Resize app window to minimum

Expected Result:

Pay button do not overlap avatar.

Actual Result:

Pay button overlaps avatar.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @CortneyOfstad
@jponikarchuk jponikarchuk added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Apr 29, 2025
Copy link

melvin-bot bot commented Apr 29, 2025

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 29, 2025
Copy link

melvin-bot bot commented Apr 29, 2025

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 29, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 29, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@grgia grgia added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 29, 2025
@grgia
Copy link
Contributor

grgia commented Apr 29, 2025

Demoting as blocker, but should still be fixed by the author of offending PR

@luacmartins
Copy link
Contributor

This view is behind a beta. @jnowakow @borys3kk could you please work on a fix?

@jnowakow
Copy link
Contributor

I'll have a look at this one

@jnowakow
Copy link
Contributor

It actually happens also on old version but since there's no "more" button it's less visible

Image

It happens only when screen has width between 800 and 909 px.

Image

I think that opinion from @Expensify/design would be valuable because maybe we should arrange header in a different way on a middle size screens?

@shawnborton
Copy link
Contributor

Yeah, I think we should use a specific breakpoint for these medium width screens that actually forces the mobile style rendering of the report header bar. Can we take that approach here?

@melvin-bot melvin-bot bot added the Overdue label May 2, 2025
@grgia
Copy link
Contributor

grgia commented May 2, 2025

How's the breakpoint idea sound @jnowakow

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 2, 2025
@jnowakow
Copy link
Contributor

jnowakow commented May 5, 2025

We have breakpoints for tablets and for mobiles:

    mobileResponsiveWidthBreakpoint: 800,
    tabletResponsiveWidthBreakpoint: 1024,

So for screens between 800 and 1024 we should display report header this way?

Image

@melvin-bot melvin-bot bot removed the Overdue label May 5, 2025
@shawnborton
Copy link
Contributor

So for screens between 800 and 1024 we should display report header this way?

That would be my vote, I think it's the cleanest approach. cc @Expensify/design for the gut check though!

@dannymcclain
Copy link
Contributor

Definitely agree.

@dubielzyk-expensify
Copy link
Contributor

Yeah that seems like a good solution to me too 👍

@luacmartins
Copy link
Contributor

luacmartins commented May 6, 2025

Agree, let's do it @jnowakow @borys3kk

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels May 7, 2025
@melvin-bot melvin-bot bot changed the title Report - Pay button overlaps avatar [Due for payment 2025-05-20] Report - Pay button overlaps avatar May 13, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 13, 2025
Copy link

melvin-bot bot commented May 13, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 13, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-20. 🎊

For reference, here are some details about the assignees on this issue:

  • @borys3kk does not require payment (Contractor)
  • @jnowakow does not require payment (Contractor)

Copy link

melvin-bot bot commented May 13, 2025

@luacmartins / @grgia @CortneyOfstad @borys3kk / @jnowakow The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 20, 2025
Copy link

melvin-bot bot commented May 20, 2025

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@CortneyOfstad
Copy link
Contributor

All good so closing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

9 participants