-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-05-20] Report - Pay button overlaps avatar #61037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @CortneyOfstad ( |
Triggered auto assignment to @grgia ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Demoting as blocker, but should still be fixed by the author of offending PR |
I'll have a look at this one |
It actually happens also on old version but since there's no "more" button it's less visible It happens only when screen has width between 800 and 909 px. I think that opinion from @Expensify/design would be valuable because maybe we should arrange header in a different way on a middle size screens? |
Yeah, I think we should use a specific breakpoint for these medium width screens that actually forces the mobile style rendering of the report header bar. Can we take that approach here? |
How's the breakpoint idea sound @jnowakow |
That would be my vote, I think it's the cleanest approach. cc @Expensify/design for the gut check though! |
Definitely agree. |
Yeah that seems like a good solution to me too 👍 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-05-20. 🎊 For reference, here are some details about the assignees on this issue: |
@luacmartins / @grgia @CortneyOfstad @borys3kk / @jnowakow The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO. |
All good so closing this out! |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v9.1.33-3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): -
Issue reported by: Applause Internal Team
Device used: MacOS Big Sur
App Component: Chat Report View
Action Performed:
Precondition: Create expense in ws chat. Submit and approve it.
Expected Result:
Pay button do not overlap avatar.
Actual Result:
Pay button overlaps avatar.
Workaround:
Unknown
Platforms:
Screenshots/Videos
1.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @CortneyOfstadThe text was updated successfully, but these errors were encountered: