Skip to content

[Due for payment 2025-05-14] [Due for payment 2025-05-08] Reports - Unable to search for task by simply typing "keyword" in the search query #61036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 of 8 tasks
mitarachim opened this issue Apr 29, 2025 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@mitarachim
Copy link

mitarachim commented Apr 29, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.33-3
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #59672
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new workspace.
  3. Submit an expense with "any" as Description and "thing" as Merchant.
  4. Create a task with "any" as Title and "thing" as Description.
  5. Go to Reports.
  6. Click on the search field.
  7. Type - type:expense status:all any and hit Enter.
  8. Type - type:expense status:all thing and hit Enter.
  9. Note that the expense from Step 3 is returned with the search query from Step 7 and 8.
  10. Go to Tasks.
  11. Type - type:task status:all any and hit Enter.
  12. Type - type:task status:all thing and hit Enter.

Expected Result:

  • Search should be able to find the keyword in task title or description and return the relevant result.
  • Search page should return "Nothing to show" empty state when there is no relevant result.

Actual Result:

  • Search is not able to find the keyword in task title or description when the search query is done without title: and description:
  • Instead of showing "Nothing to show" empty state, it shows the error page -
    Oops... Something went wrong
    Your request could not be completed. Please try again later.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image
Bug6816075_1745909536816.20250429_144410.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @OfstadC
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Apr 29, 2025
Copy link

melvin-bot bot commented Apr 29, 2025

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 29, 2025

Triggered auto assignment to @inimaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 29, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 29, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@luacmartins
Copy link
Contributor

@JS00001

@inimaga
Copy link
Contributor

inimaga commented Apr 29, 2025

New feature being introduced #59672. Removing DeployBlocker label

@NikkiWines NikkiWines removed the DeployBlocker Indicates it should block deploying the API label Apr 29, 2025
@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Apr 29, 2025
@luacmartins
Copy link
Contributor

NAB we just need to make the filter global

@inimaga inimaga added Daily KSv2 and removed Hourly KSv2 labels Apr 29, 2025
@JS00001 JS00001 self-assigned this Apr 29, 2025
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 29, 2025
@JS00001
Copy link
Contributor

JS00001 commented Apr 29, 2025

This PR was reverted and is now off of staging

@JS00001 JS00001 closed this as completed Apr 29, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 30, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 1, 2025
@melvin-bot melvin-bot bot changed the title Reports - Unable to search for task by simply typing "keyword" in the search query [Due for payment 2025-05-08] Reports - Unable to search for task by simply typing "keyword" in the search query May 1, 2025
Copy link

melvin-bot bot commented May 1, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 1, 2025
Copy link

melvin-bot bot commented May 1, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.38-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-08. 🎊

Copy link

melvin-bot bot commented May 1, 2025

@inimaga / @JS00001 @OfstadC @inimaga / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 7, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-05-08] Reports - Unable to search for task by simply typing "keyword" in the search query [Due for payment 2025-05-14] [Due for payment 2025-05-08] Reports - Unable to search for task by simply typing "keyword" in the search query May 7, 2025
Copy link

melvin-bot bot commented May 7, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.40-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-14. 🎊

Copy link

melvin-bot bot commented May 7, 2025

@inimaga / @JS00001 @OfstadC @inimaga / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@JS00001
Copy link
Contributor

JS00001 commented May 7, 2025

Doesnt need payment, this was fixed internally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants