Skip to content

[Due for payment 2025-05-14] Reports - Deleted task is still displayed on tasks list. #61023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 8 tasks
mitarachim opened this issue Apr 29, 2025 · 15 comments
Closed
3 of 8 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@mitarachim
Copy link

mitarachim commented Apr 29, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.33-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Other

Action Performed:

  1. Open the Expensify app.
  2. Open any workspace chat.
  3. Create a new task.
  4. Navigate to "Reports" section.
  5. Tap on the bookmark icon.
  6. Tap on "Tasks"
  7. Note that the just created task is displayed on top of tasks list.
  8. Return to the chat where the task was created.
  9. Open the task and tap on the header.
  10. Delete the task.
  11. Return to "Reports" > "Tasks"
  12. Note that the task is still displayed on the list, but the "Complete" button is grayed out.

Expected Result:

Deleted tasks should disappear from tasks list on "Reports" section.

Actual Result:

Deleted task remains displayed on tasks list after being deleted with the "Complete" button grayed out.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6815760_1745881901843.Tasks.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @twisterdotcom
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Apr 29, 2025
Copy link

melvin-bot bot commented Apr 29, 2025

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 29, 2025

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@github-actions github-actions bot removed the Daily KSv2 label Apr 29, 2025
Copy link

melvin-bot bot commented Apr 29, 2025

💬 A slack conversation has been started in #expensify-open-source

@MonilBhavsar
Copy link
Contributor

MonilBhavsar commented Apr 29, 2025

The tasks view was introduced in this PR #59672

@MonilBhavsar MonilBhavsar added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Apr 29, 2025
@MonilBhavsar
Copy link
Contributor

NAB as it's not blocking a user workflow

@luacmartins
Copy link
Contributor

cc @JS00001

@JS00001
Copy link
Contributor

JS00001 commented Apr 29, 2025

This PR was reverted and is now off of staging

@JS00001 JS00001 closed this as completed Apr 29, 2025
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Weekly KSv2 labels Apr 30, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels May 1, 2025
@melvin-bot melvin-bot bot changed the title Reports - Deleted task is still displayed on tasks list. [Due for payment 2025-05-08] Reports - Deleted task is still displayed on tasks list. May 1, 2025
Copy link

melvin-bot bot commented May 1, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 1, 2025
Copy link

melvin-bot bot commented May 1, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.38-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-08. 🎊

Copy link

melvin-bot bot commented May 1, 2025

@MonilBhavsar / @JS00001 @twisterdotcom @MonilBhavsar / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@twisterdotcom twisterdotcom removed the Awaiting Payment Auto-added when associated PR is deployed to production label May 2, 2025
@twisterdotcom
Copy link
Contributor

Not awaiting payment!

@twisterdotcom twisterdotcom changed the title [Due for payment 2025-05-08] Reports - Deleted task is still displayed on tasks list. Reports - Deleted task is still displayed on tasks list. May 2, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 7, 2025
@melvin-bot melvin-bot bot changed the title Reports - Deleted task is still displayed on tasks list. [Due for payment 2025-05-14] Reports - Deleted task is still displayed on tasks list. May 7, 2025
Copy link

melvin-bot bot commented May 7, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.40-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-14. 🎊

Copy link

melvin-bot bot commented May 7, 2025

@MonilBhavsar / @JS00001 @twisterdotcom @MonilBhavsar / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@JS00001
Copy link
Contributor

JS00001 commented May 7, 2025

Doesnt need payment, this was fixed internally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants