Skip to content

[$250] [Due for payment 2025-05-08] Track expense - "moved this expense to" message shows "unavailable workspace" in offline mode #60979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8 of 16 tasks
lanitochka17 opened this issue Apr 28, 2025 · 27 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 28, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.33-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: #60688
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Account has self DM
  1. Go to staging.new.expensify.com
  2. Go to self DM
  3. Submit a manual expense in self DM
  4. Go offline
  5. Click Share it with my account
  6. Select a workspace if the account has a workspace
  7. Enter merchant and select a category
  8. Click Create expense
  9. Close invite member RHP
  10. Go to transaction thread

Expected Result:

"moved this expense to" system message will not show "unavailable workspace"

Actual Result:

"moved this expense to" system message shows "unavailable workspace owes -x"

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6815651_1745873170079.20250429_044214.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021922258579568338310
  • Upwork Job ID: 1922258579568338310
  • Last Price Increase: 2025-05-13
Issue OwnerCurrent Issue Owner: @
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Apr 28, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Apr 28, 2025

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 28, 2025

💬 A slack conversation has been started in #expensify-open-source

@tgolen
Copy link
Contributor

tgolen commented Apr 28, 2025

@waterim Could you help me look into this one? It looks like it affects a message that you've recently been working on.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Apr 29, 2025
@luacmartins
Copy link
Contributor

Got a PR to fix this here

@luacmartins luacmartins self-assigned this Apr 29, 2025
@allgandalf
Copy link
Contributor

@luacmartins what's the offending PR here?

@allgandalf
Copy link
Contributor

@luacmartins I think this came from the PR:

Which is part of the Simplified actions project, whereas i am part of Report Creation Flow and Better expense report views & previews project, so i think i would be eligible for payment here in contrast to this comment, what do you think?

@luacmartins
Copy link
Contributor

yes, you would.

@github-actions github-actions bot removed the DeployBlockerCash This issue or pull request should block deployment label Apr 30, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 1, 2025
@melvin-bot melvin-bot bot changed the title Track expense - "moved this expense to" message shows "unavailable workspace" in offline mode [Due for payment 2025-05-08] Track expense - "moved this expense to" message shows "unavailable workspace" in offline mode May 1, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 1, 2025
Copy link

melvin-bot bot commented May 1, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 1, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.38-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-08. 🎊

For reference, here are some details about the assignees on this issue:

  • @allgandalf requires payment (Needs manual offer from BZ)

@melvin-bot melvin-bot bot removed the Weekly KSv2 label May 8, 2025
@melvin-bot melvin-bot bot added the Daily KSv2 label May 8, 2025
Copy link

melvin-bot bot commented May 8, 2025

Issue is ready for payment but no BZ is assigned. @zanyrenney you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented May 8, 2025

Payment Summary

Upwork Job

BugZero Checklist (@zanyrenney)

  • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@zanyrenney
Copy link
Contributor

@allgandalf prior to payment, please can you complete the checklist?

@zanyrenney
Copy link
Contributor

FYI I am OOO until Monday 12th, please expect a delay in payment!

@allgandalf
Copy link
Contributor

sorry this got shifted to daily today in my K2, so missed the last ping, it's late for me now, I'll update this issue tomorrow

@allgandalf
Copy link
Contributor

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: https://github.com/Expensify/App/pull/58597/files#r2083811310

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: N/A

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Precondition:

Test:

  1. Go to self DM > Submit a manual expense in self DM > Go offline
  2. Click Share it with my account > Select a workspace if the account has a workspace
  3. Enter merchant and select a category > Click Create expense
  4. Close invite member RHP > Go to transaction thread

Verify that the report name is correct

Do we agree 👍 or 👎

@zanyrenney
Copy link
Contributor

Regression test looks good to me - thank you!

@zanyrenney
Copy link
Contributor

Sorry @allgandalf getting this error! Will clear cache/ try again tomorrow!

Image

Thanks for your patience.

@zanyrenney zanyrenney added the External Added to denote the issue can be worked on by a contributor label May 13, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-05-08] Track expense - "moved this expense to" message shows "unavailable workspace" in offline mode [$250] [Due for payment 2025-05-08] Track expense - "moved this expense to" message shows "unavailable workspace" in offline mode May 13, 2025
Copy link

melvin-bot bot commented May 13, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021922258579568338310

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 13, 2025
Copy link

melvin-bot bot commented May 13, 2025

Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.

@zanyrenney
Copy link
Contributor

will use the automation since it is still not working to manually create a job.

@zanyrenney
Copy link
Contributor

@allgandalf please can you apply to the upwork job here - https://www.upwork.com/jobs/~021922258579568338310

thank you!

@zanyrenney
Copy link
Contributor

bump @allgandalf

@allgandalf
Copy link
Contributor

allgandalf commented May 13, 2025

Applied, thanks!!

@zanyrenney
Copy link
Contributor

offer sent @allgandalf

@allgandalf
Copy link
Contributor

offer accepted!! @zanyrenney , thankssss

@zanyrenney
Copy link
Contributor

payment summary

$250 to @allgandalf paid on upwork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants