Skip to content

Payment issue for E/App PR#59672 #60840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
melvin-bot bot opened this issue Apr 24, 2025 · 11 comments
Closed

Payment issue for E/App PR#59672 #60840

melvin-bot bot opened this issue Apr 24, 2025 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task

Comments

@melvin-bot
Copy link

melvin-bot bot commented Apr 24, 2025

Issue created to compensate the Contributor+ member for their work on #59672
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/487125.
Contributor+ member who reviewed the PR - @ZhenjaHorbach.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Apr 24, 2025
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Apr 24, 2025
Copy link
Author

melvin-bot bot commented Apr 24, 2025

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Apr 24, 2025
Copy link
Author

melvin-bot bot commented Apr 28, 2025

@isabelastisser, @ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Apr 28, 2025

Not overdue
Waiting for the PR to be in prod

@melvin-bot melvin-bot bot added Daily KSv2 and removed Overdue Daily KSv2 labels Apr 28, 2025
@isabelastisser
Copy link
Contributor

@ZhenjaHorbach, just checking in to see if this is good for payment. Thanks!

@melvin-bot melvin-bot bot added the Overdue label May 5, 2025
@isabelastisser
Copy link
Contributor

Bump @ZhenjaHorbach. Is this good for payment?

@melvin-bot melvin-bot bot removed the Overdue label May 5, 2025
@ZhenjaHorbach
Copy link
Contributor

Oh
Actually a good question 😅
I reviewed the PR
But then we decided to revert this PR
And when the new PR was created another C+ was randomly assigned
Although usually the original reviewer should continue reviewing after the revert

@JS00001
Could you please clarify what is best to do here?

@JS00001
Copy link
Contributor

JS00001 commented May 6, 2025

To be honest, I'm not sure. IDK exactly what the order of events is supposed to be, but Zhenja spent a lot of time reviewing the first PR!

@isabelastisser
Copy link
Contributor

@luacmartins tagging you here to clarify the payment details since you are assigned to the PR. Thanks!

@luacmartins
Copy link
Contributor

I think we should issue payment as usual here since it involved a considerable amount of time to review the first PR which was quite large.

@isabelastisser
Copy link
Contributor

Thanks, @luacmartins!

@isabelastisser
Copy link
Contributor

Payment summary:

@ZhenjaHorbach $250 for PR -- Pending in NewDot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task
Projects
None yet
Development

No branches or pull requests

4 participants