Skip to content

LHN - Message displayed on chat preview doesn't include "You" #60748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 18 tasks
lanitochka17 opened this issue Apr 23, 2025 · 12 comments
Closed
1 of 18 tasks

LHN - Message displayed on chat preview doesn't include "You" #60748

lanitochka17 opened this issue Apr 23, 2025 · 12 comments
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 23, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.32-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #60267
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Tap on FAB and select "Start Chat"
  3. Select an user to start a chat with
  4. Once redirected to the new chat, tap on the "+" button
  5. Select the "Pay" option
  6. Add an amount and complete the payment creation flow
  7. Return to LHN

Expected Result:

The message displayed on chat preview should be You: paid X$

Actual Result:

Message displayed on chat preview doesn't include "You"
In production there is a sender name instead of the word "You" (different behavior than staging)

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6811041_1745441992502.bandicam_2025-04-23_23-50-29-621.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Apr 23, 2025
Copy link

melvin-bot bot commented Apr 23, 2025

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 23, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@neil-marcellini
Copy link
Contributor

neil-marcellini commented Apr 24, 2025

Not a blocker because it still works fine as it does on prod. I commented on the issue explaining that a new fix needs to be tried.

@neil-marcellini neil-marcellini added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 24, 2025
@mountiny
Copy link
Contributor

@thelullabyy @suneox seems like the changes did not work completely #60267 can you take a look?

@neil-marcellini
Copy link
Contributor

I'm also just going to close this because the original issue will handle making it work correctly.

@suneox
Copy link
Contributor

suneox commented Apr 24, 2025

@thelullabyy @suneox seems like the changes did not work completely #60267 can you take a look?

It looks like this is caused by another issue where the prefix You: was removed. @thelullabyy, could you please help find the offending PR in the original issue?

@thelullabyy
Copy link
Contributor

@suneox I am checking it

@thelullabyy
Copy link
Contributor

@suneox It comes from #60307

@suneox
Copy link
Contributor

suneox commented May 1, 2025

@daledah Could you please take a look on this issue?

cc: @shubham1206agra @mountiny

@shubham1206agra
Copy link
Contributor

@suneox I think you need to adjust your PR here since our PR result was expected.

@suneox
Copy link
Contributor

suneox commented May 2, 2025

@suneox I think you need to adjust your PR here since our PR result was expected.

Let me double check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants