-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[$250] Android & iOS - Onboarding - Volume button is not responsive in "Welcome to Expensify" video #60652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @laurenreidexpensify ( |
I think this issue stems from your |
I haven't touched the volume button, recently there was an issue with the welcome video related to someone's else PR but it has been reverted I think. Will take a look tomorrow morning and prepare a fix if it is related to any of my video player PR's and if it is not and I will not find an easy fix I will let you know. |
I also noticed that the toggle play button isn’t working :) |
Job added to Upwork: https://www.upwork.com/jobs/~021915114448863890944 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 ( |
I see that Help Wanted has been added, should I look into it or leave it to externals? |
I didn’t know that. If you’re interested, feel free to take a look—otherwise, maybe another contributor might be |
Just to be sure, do you want to make those controls reactive? App/src/components/FeatureTrainingModal.tsx Lines 241 to 249 in 9379924
|
The control displays correctly—I think the issue is that VideoPlayer doesn't have a reportID |
Okay then, today I will open PR to fix this. |
Actually, I was planning to post a proposal for this in case you weren’t interested, but since you're the author and have more context, you're probably the better person for it |
Yeah, tbh I don't think it's that advanced to make a proposal and wait for it to be accepted, as you noticed it's about adding an identifier to the video player in training modal, so I created a quick PR. |
This made it to prod last week - #60821 (comment) I see @DylanDylann and @abdulrahuman5196 listed on the issue - is this a regression and therefore not valid for payment, or is anyone owed for C+ review cc @mountiny |
@mountiny can you confirm thanks ^^ |
@laurenreidexpensify No payment is required here. Let's close it |
Agreed this was a regression from the rewrite of the video player so no payments required here the authors handled it |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.31-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
Expected Result:
Volume button will be responsive
Actual Result:
Nothing happens after tapping on the volume button in "Welcome to Expensify" video
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Platforms Tested:
On which of our officially supported platforms was this issue tested:Screenshots/Videos
Add any screenshot/video evidence
Bug6809524_1745332034080.Screen_Recording_20250422_221533_Expensify.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @abdulrahuman5196The text was updated successfully, but these errors were encountered: