Skip to content

[$250] Android & iOS - Onboarding - Volume button is not responsive in "Welcome to Expensify" video #60652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 18 tasks
lanitochka17 opened this issue Apr 22, 2025 · 17 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 22, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.31-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • User has created a new account (Gmail or Expensifail) on web app and has not signed into hybrid app
  1. Launch Expensify app
  2. Log in with the new account created on web app for the first time
  3. Tap on the volume button in "Welcome to Expensify" video

Expected Result:

Volume button will be responsive

Actual Result:

Nothing happens after tapping on the volume button in "Welcome to Expensify" video

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6809524_1745332034080.Screen_Recording_20250422_221533_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021915114448863890944
  • Upwork Job ID: 1915114448863890944
  • Last Price Increase: 2025-04-23
Issue OwnerCurrent Issue Owner: @abdulrahuman5196
@lanitochka17 lanitochka17 added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Apr 22, 2025
Copy link

melvin-bot bot commented Apr 22, 2025

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@linhvovan29546
Copy link
Contributor

I think this issue stems from your rewrite video player in the #59896. @JakubKorytko

@JakubKorytko
Copy link
Contributor

JakubKorytko commented Apr 23, 2025

I haven't touched the volume button, recently there was an issue with the welcome video related to someone's else PR but it has been reverted I think. Will take a look tomorrow morning and prepare a fix if it is related to any of my video player PR's and if it is not and I will not find an easy fix I will let you know.

@linhvovan29546
Copy link
Contributor

I also noticed that the toggle play button isn’t working :)

@laurenreidexpensify laurenreidexpensify added the External Added to denote the issue can be worked on by a contributor label Apr 23, 2025
@melvin-bot melvin-bot bot changed the title Android & iOS - Onboarding - Volume button is not responsive in "Welcome to Expensify" video [$250] Android & iOS - Onboarding - Volume button is not responsive in "Welcome to Expensify" video Apr 23, 2025
Copy link

melvin-bot bot commented Apr 23, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021915114448863890944

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 23, 2025
Copy link

melvin-bot bot commented Apr 23, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

@JakubKorytko
Copy link
Contributor

I see that Help Wanted has been added, should I look into it or leave it to externals?

@linhvovan29546
Copy link
Contributor

I didn’t know that. If you’re interested, feel free to take a look—otherwise, maybe another contributor might be

@JakubKorytko
Copy link
Contributor

Just to be sure, do you want to make those controls reactive?
It feels super anti-intuitive, I think there should be no controls at all and the problem is that they are displayed there.
This video looks more like a banner animation than a real video that someone would want to control, and the code inside FeatureTrainingModal even has controlsStatus set to hide, but for some reason it doesn't work.

<VideoPlayer
url={videoURL}
videoPlayerStyle={[styles.onboardingVideoPlayer, {aspectRatio}]}
onVideoLoaded={setAspectRatio}
controlsStatus={CONST.VIDEO_PLAYER.CONTROLS_STATUS.HIDE}
shouldUseControlsBottomMargin={false}
shouldPlay
isLooping
/>

@linhvovan29546
Copy link
Contributor

The control displays correctly—I think the issue is that VideoPlayer doesn't have a reportID

@JakubKorytko
Copy link
Contributor

Okay then, today I will open PR to fix this.

@linhvovan29546
Copy link
Contributor

Actually, I was planning to post a proposal for this in case you weren’t interested, but since you're the author and have more context, you're probably the better person for it

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 24, 2025
@JakubKorytko
Copy link
Contributor

Yeah, tbh I don't think it's that advanced to make a proposal and wait for it to be accepted, as you noticed it's about adding an identifier to the video player in training modal, so I created a quick PR.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 24, 2025
@laurenreidexpensify
Copy link
Contributor

This made it to prod last week - #60821 (comment)

I see @DylanDylann and @abdulrahuman5196 listed on the issue - is this a regression and therefore not valid for payment, or is anyone owed for C+ review cc @mountiny

@laurenreidexpensify laurenreidexpensify added Daily KSv2 and removed Weekly KSv2 labels May 9, 2025
@laurenreidexpensify
Copy link
Contributor

@mountiny can you confirm thanks ^^

@DylanDylann
Copy link
Contributor

@laurenreidexpensify No payment is required here. Let's close it

@mountiny
Copy link
Contributor

Agreed this was a regression from the rewrite of the video player so no payments required here the authors handled it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review
Projects
Development

No branches or pull requests

7 participants