Skip to content

[Due for payment 2025-05-08] [Desktop Navigation] Web - LHN - Debug modal is not displayed correctly in LHN #60502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
IuliiaHerets opened this issue Apr 18, 2025 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Apr 18, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.29-9
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Left Hand Navigation (LHN)

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Have at least a report with GBR or RBR in LHN.
  1. Go to staging.new.expensify.com
  2. Press CMD+D.
  3. Enable Debug mode.
  4. Click View on the debug modal on the top right.

Expected Result:

Debug modal should be displayed correctly in LHN.

Actual Result:

Debug modal is placed at the top and overlaps with Expensify logo in LHN.
When debug RHP is opened, the modal shrunkens and overlaps with Expensify logo.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image Image https://github.com/user-attachments/assets/36ba8901-f8b7-471a-9868-8ccf71c96a75

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @miljakljajic
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Apr 18, 2025
Copy link

melvin-bot bot commented Apr 18, 2025

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 18, 2025

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 18, 2025
Copy link

melvin-bot bot commented Apr 18, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 18, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@dangrous
Copy link
Contributor

can reproduce, I think it's probably due to moving the menu to the left instead of the bottom, just need to figure out what PR that is and can go from there.

@dangrous
Copy link
Contributor

Yeah coming from #60024 - asking if we have a plan for where the menu should go / what it should look like

@marcaaron
Copy link
Contributor

This is behind a beta though right? I think we can check it off.

@marcaaron marcaaron assigned dangrous and unassigned dangrous Apr 18, 2025
@marcaaron marcaaron added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 18, 2025
@dangrous
Copy link
Contributor

oh great, yes! behind a beta

@dangrous
Copy link
Contributor

Confirming whether original team will take this one - #60024 (comment)

@mountiny mountiny changed the title Web - LHN - Debug modal is not displayed correctly in LHN [Desktop Navigation] Web - LHN - Debug modal is not displayed correctly in LHN Apr 22, 2025
@mountiny mountiny moved this to Second Cohort - CRITICAL in [#whatsnext] #migrate Apr 22, 2025
@mountiny
Copy link
Contributor

Thanks! I have assigned the folks to get this done sooner I hope

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 25, 2025
@melvin-bot melvin-bot bot changed the title [Desktop Navigation] Web - LHN - Debug modal is not displayed correctly in LHN [Due for payment 2025-05-08] [Desktop Navigation] Web - LHN - Debug modal is not displayed correctly in LHN May 1, 2025
Copy link

melvin-bot bot commented May 1, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 1, 2025
Copy link

melvin-bot bot commented May 1, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.38-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-08. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 1, 2025

@dukenv0307 @miljakljajic @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@miljakljajic
Copy link
Contributor

@dukenv0307 is owed 250 USD for their work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
Development

No branches or pull requests

7 participants