Expensify logo has same redirection as "Inbox"

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.29-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Open the ND app on Desktop
2. Sign into a valid user (HT Beta enabled user)
3. Go to a different page (For example settings)
4. Tap in Inbox
5. Go to a different page (For example settings)
6. Tap on E logo

Expected Result:

User expects the 2 buttons to have different redirections, perhaps the E button should lead to WS switcher

Actual Result:

Both buttons have the same redirection

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6805085_1744896253003.Same_redirection_for_2_different_buttons.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lakchote]

Looks like it could be related to [Desktop Navigation] Add a responsive LHB

cc @mountiny

[PiyushChandra17]

I think the both have the same Navigation.navigate() redirection, perhaps we should change it to WS switcher. Posting a proposal soon if this goes external...

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify logo has same redirection as "Inbox"

What is the root cause of that problem?

We use pressable Expensify Logo here and on click execute navigateToChats function

App/src/components/Navigation/NavigationTabBar/index.tsx

Lines 208 to 220 in 717b77a

	<PressableWithFeedback
	accessibilityRole={CONST.ROLE.BUTTON}
	accessibilityLabel="Home"
	accessible
	testID="ExpensifyLogoButton"
	onPress={navigateToChats}
	wrapperStyle={styles.leftNavigationTabBarItem}
	>
	<ImageSVG
	style={StyleUtils.getAvatarStyle(CONST.AVATAR_SIZE.DEFAULT)}
	src={Expensicons.ExpensifyAppIcon}
	/>
	</PressableWithFeedback>

What changes do you think we should make in order to solve the problem?

Use WorkspaceSwitcherButton instead, and add the wrapper style

const policy = usePolicy(activeWorkspaceID);

                        <View style={styles.leftNavigationTabBarItem}>
                            <WorkspaceSwitcherButton policy={policy} />
                        </View>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

[WojtekBoman]

Hey, this is expected behaviour, it is in line with the design doc
Here are comments where it's mentioned
#60024 (comment)
#60024 (comment)

cc: @mountiny @flaviadefaria @dannymcclain

[PiyushChandra17]

This issue is not reproducible on the latest main, can someone verify

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify logo has same redirection as "Inbox"

What is the root cause of that problem?

We are clearly redirecting to the navigateToChats here,

App/src/components/Navigation/NavigationTabBar/index.tsx

Lines 212 to 213 in 717b77a

	testID="ExpensifyLogoButton"
	onPress={navigateToChats}

Perhaps this is the root cause

What changes do you think we should make in order to solve the problem?

Instead navigateToChats, navigate to WS switcher

Replace this line:

App/src/components/Navigation/NavigationTabBar/index.tsx

Line 213 in 717b77a

onPress={navigateToChats}

with,

onPress={() => Navigation.navigate(ROUTES.WORKSPACE_SWITCHER)}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Result

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[PiyushChandra17]

Since this is deployblocker, i can help raise a quick PR.

cc: @lakchote

[lakchote]

Hey, this is expected behaviour, it is in line with the design doc Here are comments where it's mentioned #60024 (comment) #60024 (comment)

cc: @mountiny @flaviadefaria @dannymcclain

Thank you for clarifying! You are right, it's expected given what has been written in the design doc here.

Closing the issue.

[mountiny]

Thanks! We will updated the test rail cases as part of the proejct