Skip to content

[Due for payment 2025-04-28] Sign up - "What's your work email" page appears then disappears when signing up via Old Dot #60425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 8 tasks
mitarachim opened this issue Apr 17, 2025 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@mitarachim
Copy link

mitarachim commented Apr 17, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.29-3
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Other

Action Performed:

  1. Go to staging.expensify.com
  2. Select "Manage expenses for a small team".
  3. Enter email.
  4. Click Get started.
  5. Click Join.

Expected Result:

"What's your work email" page will not appear and disappear.

Actual Result:

"What's your work email" page appears then disappears when signing up via Old Dot.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6805023_1744892454454.20250417_201633.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @CortneyOfstad
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Apr 17, 2025
Copy link

melvin-bot bot commented Apr 17, 2025

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 17, 2025

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 17, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 17, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@allgandalf
Copy link
Contributor

looking, this one is interesting!!!

@blimpich
Copy link
Contributor

Assigned this to me, @allgandalf, and @ikevin127 since this is follow up for the private domain check project.

@allgandalf
Copy link
Contributor

@neil-marcellini
Copy link
Contributor

Not an API blocker since there's a frontend fix

@blimpich
Copy link
Contributor

We have a fix in the works but I'm gonna demote as I don't think this is a real blocker.

@blimpich blimpich added Daily KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment labels Apr 17, 2025
@blimpich blimpich added the Reviewing Has a PR in review label Apr 18, 2025
@blimpich
Copy link
Contributor

blimpich commented Apr 18, 2025

Fix was merged, marking this as in-review since it still will have to go through QA

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Apr 21, 2025
@melvin-bot melvin-bot bot changed the title Sign up - "What's your work email" page appears then disappears when signing up via Old Dot [Due for payment 2025-04-28] Sign up - "What's your work email" page appears then disappears when signing up via Old Dot Apr 21, 2025
Copy link

melvin-bot bot commented Apr 21, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 21, 2025
Copy link

melvin-bot bot commented Apr 21, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.30-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-28. 🎊

For reference, here are some details about the assignees on this issue:

  • @ikevin127 requires payment (Needs manual offer from BZ)
  • @allgandalf requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Apr 21, 2025

@ikevin127 / @allgandalf @CortneyOfstad @ikevin127 / @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@ikevin127
Copy link
Contributor

@CortneyOfstad This is a regression coming from our main PR, no payments needed here - can be closed 👍

@CortneyOfstad
Copy link
Contributor

Sounds good — thanks @ikevin127!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants