[Due for payment 2025-04-28] [Due for payment 2025-04-25] Review duplicates - Receipt thumbnail on the confirmation page does not have right margin

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.29-3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit two expenses with the same amount and merchant.
4. Go to transaction thread of any expense.
5. Click Review duplicates.
6. Click Keep this one on any preview.

Expected Result:

Receipt thumbnail on the confirmation page will have right margin.

Actual Result:

Receipt thumbnail on the confirmation page does not have right margin.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[NikkiWines]

Discussing in slack

[Eskalifer1]

Discussing in slack

Can i have access to slack please?)

[ntdiary]

Can i have access to slack please?)

https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#slack-channels
@Eskalifer1, here’s how to apply, but I’m not sure if the issue with adding users has been resolved yet. :)

[Eskalifer1]

Can i have access to slack please?)

https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#slack-channels @Eskalifer1, here’s how to apply, but I’m not sure if the issue with adding users has been resolved yet. :)

Yep, i have applied about 1.5 week ago) Still waiting

[Eskalifer1]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-17 13:08:21 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Review duplicates - Receipt thumbnail on the confirmation page does not have right margin

What is the root cause of that problem?

The main problem is as follows:
ReceiptEmptyState - has styles for margin, as a result, with a width of 100% and maxWidth of 360px, it takes up 360px, but since we still have 40px in total margin, it is offset.

What changes do you think we should make in order to solve the problem?

I suggest adding another prop called isInSideBar (or isFromReviewDuplicates). If this value is true, then add maxWidth: 335px(375px-40px)

And this component is used in the MoneyRequestView, but there is already a prop called isFromReviewDuplicates
Add here new prop(after that line):

App/src/components/ReceiptEmptyState.tsx

Line 28 in 717b77a

shouldUseFullHeight?: boolean;

/** Whether the component is used in the sidebar */

    isInSideBar?: boolean;

Add new style(can be also called expenseViewImageInSideBar):

expenseViewImageFromReviewDuplicates: {
            maxWidth: 335,
        },

Add this row:

isInSideBar && styles.expenseViewImageFromReviewDuplicates,

To this styles(after that row):

App/src/components/ReceiptEmptyState.tsx

Line 53 in 717b77a

shouldUseFullHeight && styles.receiptEmptyStateFullHeight,

And pass this prop from here:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 562 in 717b77a

<ReceiptEmptyState

Like that:

isInSideBar={isFromReviewDuplicates}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

An alternative solution would be to rewrite the component so that the container is not padded, but rather the card itself. But this method is more difficult + still requires certain conditions inside, because in the display in Expense it would have indents, and this should not be the case
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[FitseTLT]

Raised the fix Uploading snapshots....

[marcaaron]

Fix deployed to staging. I asked QA to retest this one.

[kavimuru]

@marcaaron bug is not reproducible

Screen.Recording.2025-04-18.at.8.07.17.AM.1.mov

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.29-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix - Review duplicates - Receipt thumbnail on the confirmation page does not have right margin #60427

If no regressions arise, payment will be issued on 2025-04-25. 🎊

[melvin-bot]

@NikkiWines / @marcaaron @alexpensify @NikkiWines / @marcaaron The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.30-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix - Review duplicates - Receipt thumbnail on the confirmation page does not have right margin #60427

If no regressions arise, payment will be issued on 2025-04-28. 🎊

[melvin-bot]

@NikkiWines / @marcaaron @alexpensify @NikkiWines / @marcaaron The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[alexpensify]

@marcaaron, can you please confirm? I believe that @FitseTLT and @ahmedGaber93 helped fix this one. If yes, I need to prepare for the payment date on Monday. Thanks!

[FitseTLT]

@marcaaron, can you please confirm? I believe that @FitseTLT and @ahmedGaber93 helped fix this one. If yes, I need to prepare for the payment date on Monday. Thanks!

@alexpensify, please close it.

[alexpensify]

@FitseTLT thanks, after my comment, I saw that there is another GH where the payment will happen. Thanks again for the update.