Skip to content

Profile - Missing the copy button in the Profile #60411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 of 8 tasks
jponikarchuk opened this issue Apr 17, 2025 · 7 comments
Closed
5 of 8 tasks

Profile - Missing the copy button in the Profile #60411

jponikarchuk opened this issue Apr 17, 2025 · 7 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2

Comments

@jponikarchuk
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.29-3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: User Settings

Action Performed:

  1. Log in to the ND and open a chat with a user
  2. Click on the user profile

Expected Result:

The app should have a copy button in the profile, like the Prod

Actual Result:

The app missing the copy button

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

@jponikarchuk jponikarchuk added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Apr 17, 2025
Copy link

melvin-bot bot commented Apr 17, 2025

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 17, 2025

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 17, 2025

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 17, 2025
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 17, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@nkdengineer
Copy link
Contributor

nkdengineer commented Apr 17, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app missing the copy button

What is the root cause of that problem?

We remove the CommunicationsLink in this PR #59731

And didn't add the copy icon in here

{!(isCurrentUser && isAnonymousUserSession()) && login ? (
<View style={[styles.w100, styles.detailsPageSectionContainer]}>
<MenuItemWithTopDescription
style={[styles.ph0]}
title={isSMSLogin ? formatPhoneNumber(phoneNumber ?? '') : login}
copyValue={isSMSLogin ? formatPhoneNumber(phoneNumber ?? '') : login}
description={translate(isSMSLogin ? 'common.phoneNumber' : 'common.email')}
interactive={false}
/>
</View>
) : null}

What changes do you think we should make in order to solve the problem?

We can use ContextMenuItem like we did with other places

                <ContextMenuItem
                    icon={Expensicons.Copy}
                    text={translate('reportActionContextMenu.copyToClipboard')}
                    successIcon={Expensicons.Checkmark}
                    successText={translate('reportActionContextMenu.copied')}
                    isMini
                    onPress={() => Clipboard.setString(isSMSLogin ? formatPhoneNumber(phoneNumber ?? '') : login)}
                />
Screen.Recording.2025-04-17.at.13.59.33.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@jjcoffee
Copy link
Contributor

We removed this on purpose in order to have one copy method across the app, so this item is actually copyable (by press-and-hold or right click). cc @blimpich @sosek108

@Gonals Gonals removed the DeployBlockerCash This issue or pull request should block deployment label Apr 17, 2025
@Gonals
Copy link
Contributor

Gonals commented Apr 17, 2025

Closing, then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants