Skip to content

[Due for payment 2025-04-28] [Due for payment 2025-04-25] Search-Search syntax is not added to the field after clicking to search in the current chat #60395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 8 tasks
mitarachim opened this issue Apr 17, 2025 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

mitarachim commented Apr 17, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.-29-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5942880
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: MacBook Air 15.4 Chrome, iPhone 15 iOS 18.3.2 Safari
App Component: Search

Action Performed:

  1. Navigate to the staging.new.expensify.com and sign in
  2. Start a 1:1 conversation, say some messages like "Hi", "Hello"
  3. While on the conversation page, click on the Search icon at the top right corner
  4. Select an option to search in the current conversation
  5. Check the search box

Expected Result:

A search syntax is added to the search box after clicking on the option to search in the current conversation

Actual Result:

A search syntax is not added to the search box after clicking on the option to search in the current conversation. User is not able to complete the search query in the search field on the chat page

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6804401_1744846735292.Recording__97.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @alexpensify
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Apr 17, 2025
Copy link

melvin-bot bot commented Apr 17, 2025

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 17, 2025

Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 17, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 17, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mollfpr mollfpr removed the DeployBlocker Indicates it should block deploying the API label Apr 17, 2025
@mollfpr
Copy link
Contributor

mollfpr commented Apr 17, 2025

It will fixed here #60417

@rezkiy37
Copy link
Contributor

It will fixed here #60417

I can confirm it is fixed there.

Video

Chrome.mp4

@marcaaron
Copy link
Contributor

Are we going to CP that PR? Who's working on this?

@marcaaron marcaaron assigned marcaaron and unassigned mollfpr Apr 18, 2025
@marcaaron
Copy link
Contributor

PR is now reviewed and tested but has conflicts.

@marcaaron
Copy link
Contributor

Re-tested this one and checking it off:

Image
Image

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 18, 2025
@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Apr 18, 2025
@melvin-bot melvin-bot bot changed the title Search-Search syntax is not added to the field after clicking to search in the current chat [Due for payment 2025-04-25] Search-Search syntax is not added to the field after clicking to search in the current chat Apr 18, 2025
Copy link

melvin-bot bot commented Apr 18, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.29-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-25. 🎊

Copy link

melvin-bot bot commented Apr 18, 2025

@marcaaron @alexpensify @marcaaron The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 21, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-04-25] Search-Search syntax is not added to the field after clicking to search in the current chat [Due for payment 2025-04-28] [Due for payment 2025-04-25] Search-Search syntax is not added to the field after clicking to search in the current chat Apr 21, 2025
Copy link

melvin-bot bot commented Apr 21, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.30-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-28. 🎊

Copy link

melvin-bot bot commented Apr 21, 2025

@marcaaron @alexpensify @marcaaron The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 25, 2025
@alexpensify
Copy link
Contributor

Closing - I believe the payment process for this one is being handled here: #59262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants