[Due for payment 2025-04-30] [Desktop Navigation] [$125] Chat - + menu overlaps with LHN

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.29-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Chat Report View

Action Performed:

Precondition:

• Log in with Expensifail account.

1. Go to staging.new.expensify.com
2. Go to any chat.
3. Click + button.

Expected Result:

• menu will stay within report view and will not overlap with LHN.

Actual Result:

• menu does not stay within report view and it overlaps with LHN.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6804353_1744844095078.20250417_065312.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021912904231559983874
• Upwork Job ID: 1912904231559983874
• Last Price Increase: 2025-04-18

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[marcaaron]

I can't reproduce this at all. Can you reliably reproduce this? And on different test accounts?

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - + menu overlaps with LHN

What is the root cause of that problem?

We calculate the + menu popover position here but didn't take into account the left navigation bar width to offset the popover horizontally:

App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

Line 404 in 9fe7bda

anchorPosition={styles.createMenuPositionReportActionCompose(shouldUseNarrowLayout, windowHeight, windowWidth)}

App/src/styles/index.ts

Lines 1854 to 1859 in 3385c18

	createMenuPositionReportActionCompose: (shouldUseNarrowLayout: boolean, windowHeight: number, windowWidth: number) =>
	({
	// On a narrow layout the menu is displayed in ReportScreen in RHP, so it must be moved from the right side of the screen
	horizontal: (shouldUseNarrowLayout ? windowWidth - variables.sideBarWidth : variables.sideBarWidth) + 18,
	vertical: windowHeight - CONST.MENU_POSITION_REPORT_ACTION_COMPOSE_BOTTOM,
	} satisfies AnchorPosition),

What changes do you think we should make in order to solve the problem?

Take into account the left navigation bar width offset if it renders based on canUseLeftHandBar permission:

createMenuPositionReportActionCompose: (shouldUseNarrowLayout: boolean, windowHeight: number, windowWidth: number, canUseLeftHandBar?: boolean) =>
  ({
      horizontal: (shouldUseNarrowLayout ? windowWidth - variables.sideBarWidth : (canUseLeftHandBar ? (variables.sideBarWithLHBWidth + variables.navigationTabBarSize) : variables.sideBarWidth)) + 18,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[gijoe0295]

@marcaaron Need to enable canUseLeftHandBar locally.

[marcaaron]

Ok since it is behind a beta then it's not a blocker.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The menu does not stay within the report view and overlaps with the Left-Hand Navigation (LHN).

What is the root cause of that problem?

• The popover menu’s position is calculated in the following files:

  • AttachmentPickerWithMenuItems.tsx (line 406)
  • styles/index.ts (line 1857)

• The current positioning uses fixed values rather than dynamic layout awareness, which causes incorrect placement when the sidebar width or position changes.

What changes do you think we should make in order to solve the problem?

• Instead of calculating the popover’s position based on fixed values, we should dynamically measure the position of the anchor component—the "+" button—and place the popover accordingly.

Here’s a proposed implementation:

const [popoverPosition, setPopoverPosition] = useState(
    styles.createMenuPositionReportActionCompose(
        shouldUseNarrowLayout,
        windowHeight,
        windowWidth
    )
);

useEffect(() => {
    if (!actionButtonRef.current || !isMenuVisible || !isFocused) {
        return;
    }

    actionButtonRef.current.measureInWindow((x, y, width, height) => {
        setPopoverPosition({
            horizontal: x,
            vertical: windowHeight - CONST.MENU_POSITION_REPORT_ACTION_COMPOSE_BOTTOM,
        });
    });
}, [isMenuVisible, isFocused, windowWidth]);</code></pre>

• Then, use anchorPosition={popoverPosition} at the popover rendering point:

  • AttachmentPickerWithMenuItems.tsx (line 404)

This ensures that the popover remains anchored to the "+" button regardless of changes to layout or screen width.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• N/A

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021912904231559983874

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - + menu overlaps with LHN

What is the root cause of that problem?

We have updated the UI to add the NavigationTabBar on the left.

But, when we calculate createMenuPositionReportActionCompose, we did not include the NavigationTabBar width, so this happened.

App/src/styles/index.ts

Line 1919 in 6d85317

horizontal: (shouldUseNarrowLayout ? windowWidth - variables.sideBarWidth : variables.sideBarWidth) + 18,

What changes do you think we should make in order to solve the problem?

To resolve this issue, we simply add the NavigationTabBar width when calculating the horizontal of createMenuPositionReportActionCompose, like this:

App/src/styles/index.ts

Line 1919 in 6d85317

horizontal: (shouldUseNarrowLayout ? windowWidth - variables.sideBarWidth : variables.sideBarWidth) + 18,

update to:

horizontal: (shouldUseNarrowLayout ? windowWidth - variables.sideBarWidth : variables.sideBarWidth + 71 - 18) + 18,

71 is the NavigationTabBar width, which will be defined as a constant in the PR phase.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[shawnborton]

That seems like a bug related to the new LHB changes, cc @WojtekBoman @mountiny for visibility

[melvin-bot]

Upwork job price has been updated to $125

[mountiny]

Decreasing the pay out as its a simple position change and bucketing it to the project

@dukenv0307 as c+ on the project can tou please review the proposals. Thanks

[thelullabyy]

@ntdiary The current bug appears because the popover’s position is based on the fixed values. Why don't we dynamically measure the popover's position based on its anchor component ("+" button)? It is the common logic we use to calculate other popovers.

[ntdiary]

@ntdiary The current bug appears because the popover’s position is based on the fixed values. Why don't we dynamically measure the popover's position based on its anchor component ("+" button)? It is the common logic we use to calculate other popovers.

@thelullabyy, another c+ will take over this issue and will re-review the proposal above. :)

[WojtekBoman]

I can take care of it as I'm the author of the offending PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.31-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Desktop Navigation] Fix UI issues related to LHB  #60493

If no regressions arise, payment will be issued on 2025-04-30. 🎊

For reference, here are some details about the assignees on this issue:

• @WojtekBoman does not require payment (Contractor)
• @dukenv0307 requires payment through NewDot Manual Requests

[melvin-bot]

@dukenv0307 @lschurr @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[dukenv0307]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

• Precondition:

Log in with Expensifail account.

1. Go to staging.new.expensify.com
2. Go to any chat.
3. Click + button.
4. Menu will stay within report view and will not overlap with LHN.

Do we agree 👍 or 👎

[mountiny]

This can be closed - project will be paid out in one go and regression tests will be added then likewise by Flavia or Danny