Skip to content

[Due for payment 2025-04-25] Disable resolved ConciergeCategoryOptions actions instead of hiding them #60136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasperhuangg opened this issue Apr 11, 2025 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.

Comments

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Apr 11, 2025

Problem

The UX of hiding resolved ConciergeCategoryOptions actions feels weird right now. They just suddenly disappear and the responses to them have no context.

Solution

Rather than hiding them, just disable them by either greying them out or turning the buttons into text.

NOTE: To the contributor/C+ working on this, please be requested to be added to the beta.

You can check if the ConciergeCategoryOptions action is resolved by using ReportActionUtils.isResolvedConciergeCategoryOptions

Image

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021911869023812459029
  • Upwork Job ID: 1911869023812459029
  • Last Price Increase: 2025-04-14
Issue OwnerCurrent Issue Owner: @jjcoffee
@jasperhuangg jasperhuangg self-assigned this Apr 11, 2025
@jasperhuangg jasperhuangg added Daily KSv2 NewFeature Something to build that is a new item. labels Apr 11, 2025
Copy link

melvin-bot bot commented Apr 11, 2025

Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 11, 2025
Copy link

melvin-bot bot commented Apr 11, 2025

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Apr 11, 2025

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

@jasperhuangg
Copy link
Contributor Author

Image

Ah woops, I realize that this was actually part of the original design. @dannymcclain please ignore this!

@jasperhuangg jasperhuangg added External Added to denote the issue can be worked on by a contributor Daily KSv2 and removed Weekly KSv2 labels Apr 11, 2025
@melvin-bot melvin-bot bot changed the title Disable resolved ConciergeCategoryOptions actions instead of hiding them [$250] Disable resolved ConciergeCategoryOptions actions instead of hiding them Apr 11, 2025
Copy link

melvin-bot bot commented Apr 11, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021910750263507700710

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 11, 2025
@jasperhuangg jasperhuangg added Engineering and removed Help Wanted Apply this label when an issue is open to proposals by contributors labels Apr 11, 2025
Copy link

melvin-bot bot commented Apr 11, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

@jasperhuangg jasperhuangg removed the External Added to denote the issue can be worked on by a contributor label Apr 11, 2025
@jasperhuangg
Copy link
Contributor Author

I'll tackle this myself

@dannymcclain
Copy link
Contributor

Ah woops, I realize that this was actually part of the original design.

Haha yup! No worries though!

@jasperhuangg jasperhuangg changed the title [$250] Disable resolved ConciergeCategoryOptions actions instead of hiding them Disable resolved ConciergeCategoryOptions actions instead of hiding them Apr 11, 2025
@melvin-bot melvin-bot bot added the Overdue label Apr 14, 2025
@jasperhuangg jasperhuangg added the External Added to denote the issue can be worked on by a contributor label Apr 14, 2025
@melvin-bot melvin-bot bot changed the title Disable resolved ConciergeCategoryOptions actions instead of hiding them [$250] Disable resolved ConciergeCategoryOptions actions instead of hiding them Apr 14, 2025
@jasperhuangg jasperhuangg added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 14, 2025
Copy link

melvin-bot bot commented Apr 14, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021911869023812459029

Copy link

melvin-bot bot commented Apr 14, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

@melvin-bot melvin-bot bot removed the Overdue label Apr 14, 2025
@jasperhuangg jasperhuangg removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Apr 14, 2025
@jasperhuangg jasperhuangg changed the title [$250] Disable resolved ConciergeCategoryOptions actions instead of hiding them Disable resolved ConciergeCategoryOptions actions instead of hiding them Apr 14, 2025
@jasperhuangg jasperhuangg added the Reviewing Has a PR in review label Apr 15, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Apr 18, 2025
@melvin-bot melvin-bot bot changed the title Disable resolved ConciergeCategoryOptions actions instead of hiding them [Due for payment 2025-04-25] Disable resolved ConciergeCategoryOptions actions instead of hiding them Apr 18, 2025
Copy link

melvin-bot bot commented Apr 18, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 18, 2025
Copy link

melvin-bot bot commented Apr 18, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.29-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-25. 🎊

Copy link

melvin-bot bot commented Apr 18, 2025

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@jasperhuangg] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Apr 25, 2025
Copy link

melvin-bot bot commented Apr 28, 2025

@jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@jasperhuangg
Copy link
Contributor Author

Regression tests already exist for this!

@melvin-bot melvin-bot bot removed the Overdue label Apr 28, 2025
@jasperhuangg
Copy link
Contributor Author

No payment needed as no C+ was used for this issue, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

5 participants