[$250] [Due for payment 2025-04-25] Pass transactionID to OpenReport to allow creating transaction threads for historical reports

[marcaaron]

App companion to https://github.com/Expensify/Expensify/issues/483023

Let's update the Reports page in NewDot to support unreported expenses, whether or not those unreported expenses have been added to the selfDM. This will allow us to support all historical unreported expenses that existed prior to the selfDM.

Unreported expenses outside the selfDM have no parentReportAction or parentReportID. In order to support them we will need at minimum to:

Update the Search command to return these expenses in any search query that should be returning unreported expenses
Support displaying these expenses on the Reports page
Update the OpenReport command to be able to display these expenses when clicked on from the Reports page by creating a transaction thread and parent report action on the selfDM

There is a draft PR that was closed here that can be used as a guide. We effectively need to cover this situation:

• An unreported transaction exists but has no transaction thread associated with it.
• We will create the transaction thread and the money request report action by passing a transactionID and a moneyRequestPreviewReportActionID param.
• The backend will create these and return then.
• The frontend must create the optimistic versions and populate the Onyx data so they load right away before the API finishes.

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021915810134956511772
• Upwork Job ID: 1915810134956511772
• Last Price Increase: 2025-04-25

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Triggered auto assignment to @lschurr (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

[marcaaron]

Just a heads up that there are some backend implementation issues that testing for this is blocked on, but it can be worked on now.

[nkdengineer]

An unreported transaction exists but has no transaction thread associated with it.
We will create the transaction thread and the money request report action by passing a transactionID and a moneyRequestPreviewReportActionID param.
The backend will create these and return then.
The front end must create the optimistic versions and populate the Onyx data so they load right away before the API finishes.

@marcaaron I'd like to work on this. Since the detailed steps are outlined in the OP, and we also have the draft here, do I still need to post a proposal?

[marcaaron]

Hey @nkdengineer I assigned some people internally before seeing this. Look forward to working with you again next time!

[ikevin127]

♻ Will start working on opening a draft PR today.

[ikevin127]

@marcaaron Draft PR #60077 is ready for a preliminary review from you. I detailed the Explanation of Change in the PR description.

Additionally, could you provide some testing steps to verify whether the PR does what it's supposed to do ?

I wasn't able to figure out how to see unreported expenses in ND Reports (search) page and see what happens when clicked on one on current staging / vs the draft PR.

[marcaaron]

Checking it out right now. I'll do the testing locally to confirm that it all works. We will still need to wait for a BE change (internal gh) to get deployed before merging, but the changes should be on staging soon.

[marcaaron]

Alright the last BE PR is on staging now heading for production. So, we should be able to test the app PR once that happens.

[marcaaron]

though actually, we can also test against the staging server. I probably have some historical expenses I can use that don't have transaction threads. and that should be enough, but we'll hold the App PR until this (internal link) hits prod.

[marcaaron]

That PR is on production now so I will proceed with testing and merge!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.29-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• New Feature: Support NewDot Unreported Expenses #60077

If no regressions arise, payment will be issued on 2025-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @ikevin127 requires payment (Needs manual offer from BZ)
• @rayane-d requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ikevin127 / @rayane-d] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[ikevin127]

• @ikevin127 Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

I don't think we need regression tests here due to difficulty of reproducing and testing unreported expenses, @marcaaron for confirmation on this.

[marcaaron]

I agree and don't think it's practical to do regression tests on this. If customers experience issues with it we will find out and fix it.

[rayane-d]

Kindly unassign me. The review was conducted internally.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021915810134956511772

[melvin-bot]

Current assignee @ikevin127 is eligible for the External assigner, not assigning anyone new.

[lschurr]

Just adding External to get the job created in Upwork

[lschurr]

Offer sent @ikevin127 - https://www.upwork.com/nx/wm/offer/107063894

[ikevin127]

@lschurr Offer accepted, thank you!

[lschurr]

Payment summary:

• Contributor: $250 @ikevin127 (paid in Upwork)