Skip to content

[Due for payment 2025-04-16] [Better Expense Report View] New expense report preview does not have Export button #59515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8 tasks done
IuliiaHerets opened this issue Apr 2, 2025 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Apr 2, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.22-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #58479
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Workspace is connected to Intacct.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit a manual expense to the workspace chat.
  4. Click Submit.
  5. Click Approve.
  6. Click Pay elsewhere.

Expected Result:

There should be an Export button on the expense preview to export the report to Intacct (old preview has Export button).

Actual Result:

There is no Export button on the expense preview to export the report to Intacct.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/b77bcdce-683f-4e0b-b2ac-59393cbe7e91
Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @kadiealexander
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Apr 2, 2025
Copy link

melvin-bot bot commented Apr 2, 2025

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 2, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link

melvin-bot bot commented Apr 2, 2025

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 2, 2025
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 2, 2025
Copy link
Contributor

github-actions bot commented Apr 2, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

I added a blocker label, as it is not repro on prod, it is a new feature.
If no need to add this label, let me know, and I will delete it, or you can do it by yourself.

@techievivek techievivek added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 2, 2025
@techievivek
Copy link
Contributor

This is behind beta so removing the blocker label.

@techievivek
Copy link
Contributor

@Guccio163 @mountiny do you wanna take a look into it?

@Guccio163
Copy link
Contributor

Yup, looks like one of ours 👍

@jliexpensify
Copy link
Contributor

Kadie is OOO for the next 2 days, @techievivek feel free to ping me if you need anything actioned on this from the B0 end

@mountiny
Copy link
Contributor

mountiny commented Apr 3, 2025

Added to the project and took it on, thanks!

@mountiny mountiny changed the title Expense - New expense report preview does not have Export button [Better Expense Report View] New expense report preview does not have Export button Apr 3, 2025
Copy link

melvin-bot bot commented Apr 7, 2025

@Guccio163 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Apr 7, 2025
@allgandalf
Copy link
Contributor

go away melv

@mountiny
Copy link
Contributor

mountiny commented Apr 7, 2025

This one should be fixed with #59718, I think we can close this issue as no payments are needed and regression testing will be handled as part of the project

@mountiny mountiny closed this as completed Apr 7, 2025
@github-project-automation github-project-automation bot moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrate Apr 7, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Apr 9, 2025
@melvin-bot melvin-bot bot changed the title [Better Expense Report View] New expense report preview does not have Export button [Due for payment 2025-04-16] [Better Expense Report View] New expense report preview does not have Export button Apr 9, 2025
Copy link

melvin-bot bot commented Apr 9, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.24-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-16. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Apr 9, 2025

@allgandalf @kadiealexander @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
Development

No branches or pull requests

8 participants