[Due for payment 2025-04-16] [Better Expense Report View] Reply count is not removed together with expense preview after deleting expense

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue was found while executing QA for PR #58479

Version Number: 9.1.22-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #58479
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Log in with Expensifail account.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit a manual expense.
4. Right click on the expense preview > Reply in thread.
5. Send a message to the expense report.
6. Go back to main workspace chat.
7. Right click on the expense preview > Delete expense.
8. Delete the expense.

Expected Result:

The reply count will be removed together with the expense preview.

Actual Result:

The reply count is not removed together with the expense preview. The expense preview disappears first, then the reply count disappears.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[vincdargento]

@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[grgia]

Demoting, not a blocker

[grgia]

@allgandalf is under beta?

[Guccio163]

Yes, it is under beta, though I'm not sure if this is a bug caused exactly by this PR, since ReportAction is the component responsible for rendering (and hence not rendering) the Carousel - will look for this though, wdyt @mountiny ?.

[mountiny]

Seems like it might be related to some of our changes so adding to the project and we can follow up on this one

[garrettmknight]

@mountiny do you have an issue to keep an eye on for this one specifically, or just the project in general?

[mountiny]

We are going to use this one (this specific issue was not specified before), @JakubKorytko is on it

[allgandalf]

PR was merged, good to close after deployment

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.24-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Better Expense Report View] Remove reply count together with expense preview after deleting last expense  #59679

If no regressions arise, payment will be issued on 2025-04-16. 🎊

For reference, here are some details about the assignees on this issue:

• @JakubKorytko does not require payment (Contractor)
• @Guccio163 does not require payment (Contractor)
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

@allgandalf @garrettmknight @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[mountiny]

this can be closed as regression tests and payments are handled as whole in the project