Skip to content

Fix authentication pages onyxData key for tryNewDot NVP #59460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Julesssss opened this issue Apr 1, 2025 · 4 comments
Closed

Fix authentication pages onyxData key for tryNewDot NVP #59460

Julesssss opened this issue Apr 1, 2025 · 4 comments
Assignees
@Julesssss
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@Julesssss
Copy link
Contributor

Julesssss commented Apr 1, 2025 •
edited
Loading

Problem

Recently i started providing tryNewDot onyxData to the client to unblock the switch to React Native authentications (and our new homepage) pages on HybridApp.

The onyxKey needs to use the NVP_ prefix.

Solution

Update the key from tryNewDot to nvp_trynewDot.
@Julesssss Julesssss added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering labels Apr 1, 2025
@Julesssss Julesssss self-assigned this Apr 1, 2025
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 1, 2025

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@Julesssss Julesssss added the Internal Requires API changes or must be handled by Expensify staff label Apr 1, 2025
@Julesssss
Copy link
Contributor Author

Hey @lydiabarclay this issue is just for tracking. Nothing for you to do here.

@Julesssss Julesssss added the Reviewing Has a PR in review label Apr 3, 2025
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 17, 2025

@Julesssss Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@Julesssss
Copy link
Contributor Author

Done

@github-project-automation github-project-automation bot moved this from LOW to Done in [#whatsnext] #quality Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Julesssss Julesssss

Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
[#whatsnext] #quality
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Julesssss @lydiabarclay