[Due for payment 2025-05-14] [Due for payment 2025-04-17] [Desktop Navigation] Add a dedicated Workspace filter to the Reports tab

[mountiny]

Part of https://github.com/Expensify/Expensify/issues/468845

Implement this section of the Design doc (linking to the tasks section as this project is being handled by SWM).

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[WojtekBoman]

Hey, I'm going to work on it

[WojtekBoman]

Hey @dannymcclain

I’m working on a new workspace filter screen and I have 2 questions about this feature:

1. Do we want to add a save button at the bottom of this screen like in other filter screens?
2. On designs we don’t have an input for a search term, should it be displayed on this page?

Screen.Recording.2025-04-01.at.11.43.22.mov

[dannymcclain]

Do we want to add a save button at the bottom of this screen like in other filter screens?

Yes I think we should. @Expensify/design @JmillsExpensify for a gut check, but my thinking is that even though this is single select (for now), we should go ahead and include the save button because with the work we're going to do with suggested searches and filter updates, we'll have one. So we might as well just include it now to make that smoother.

On designs we don’t have an input for a search term, should it be displayed on this page?

The typical rule we follow is if there are 8 list items or more, we include the search input. Can we implement that same logic here?

[shawnborton]

but my thinking is that even though this is single select (for now), we should go ahead and include the save button because with the work we're going to do with suggested searches and filter updates, we'll have one. So we might as well just include it now to make that smoother.

I can see that point... at the same time, we don't really have any Save buttons on single select push pages, so if we want to be consistent in the meantime, I think what is being shown is technically the most correct.

[dannymcclain]

Yeah you're totally right. If you all think it's better to be consistent for now that's totally fine with me! I was just thinking about The Future™. But happy to just implement that when we need instead of right now.

[dubielzyk-expensify]

I'm personally for the Save button because every single filter that we have today in the Reports page have a Save button, so it would be weird to me that one of the filters don't have it, but the rest do.

[shawnborton]

But I think that's because every filter so far is multi-select, right?

[shawnborton]

So if we are adding a multi-select filter, then we should add a Save button. But if it's just a single select (you can only pick one option), then I think we don't need the Save button.

[WojtekBoman]

Ok, so if we don't add a save button, I wonder how should I implement resetting the value in this input? If we have a save button, we can simply click the button a second time, but how should we handle this in this case? cc: @Expensify/design

[shawnborton]

The pattern we typically use is that you just tap on the selected item, which would unselect it.

[dubielzyk-expensify]

But if it's just a single select (you can only pick one option), then I think we don't need the Save button.

Are you suggesting that the back buttons saves then or that it auto-navigates back, @shawnborton ?

[shawnborton]

The back button just takes you back. When you click on an option, it auto saves and then brings you back to the previous screen.

[dubielzyk-expensify]

Right. I think that's the part that I don't love. That in that filter menu some auto-take-you-back and some stay waiting for the user to tap Save. Feels a bit inconsistent. Maybe this won't feel as bad as I make it out to be though. Happy to lean on you and hear what @dannymcclain thinks

[shawnborton]

What part is inconsistent though? I'm pretty sure all multi-selects have a save button, and all single selects don't. So we're at least consistent with how we treat them, right?

[WojtekBoman]

Maybe it'll be helpful, here's a video showing how it's currently implemented:

Screen.Recording.2025-04-02.at.12.49.17.mov

Does it meet your expectations?

[shawnborton]

Close! I would expect to see some kind of "Save search" button once you start modifying the filters, right?

And then just to confirm, for the workspace filter, right now we are only allowing you to select one workspace at a time. Is that right @Expensify/design?

[dannymcclain]

And then just to confirm, for the workspace filter, right now we are only allowing you to select one workspace at a time. Is that right @Expensify/design?

Yes, that is correct for now. And the behavior @WojtekBoman is showing in that video is what I would expect based on the convo above (except for Shawn's comment about the Save search / View results buttons).

I think the point Jon is making is that within the context of filters, this screen behaves differently than all the rest if we don't include a save button. I totally understand that the interaction shown in the video is consistent with other single-select lists in the app (i.e. selecting a category on an expense) but it does behave differently than the other filters (and again, yes, that's because all our other filters are multi-select). I was proposing that we go ahead and include the save button here because once we do all the suggested search updates, every filter, single or multi-select, will get a save/apply and reset button. But I really don't feel too strongly because that work is coming down the pipe in near-ish future anyways. So to me it doesn't super matter if we do it now or later. Happy to just do it when we rework all of the filters.

[mountiny]

@WojtekBoman, what would be your thoughts on the increased complexity of implementing multi-selection now?

I would keep multiselect for follow up as it would slow us down, we can add it to the follow ups for the project though

[dannymcclain]

All of the above sounds good to me! Happy to yield to Shawn's 8/10!

And then for multiselect, I agree with Vit, let's keep that as a follow up. If I'm remembering correctly, multiselect gets a little dicey with routing or something? #not-an-engineer but I feel like I remember it being a bigger deal than simply letting people select more than one workspace.

[flaviadefaria]

I would keep multiselect for follow up as it would slow us down, we can add it to the follow ups for the project though

Cool, if it adds more complexity, then let's definitely leave it as a follow-up.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.25-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Desktop Navigation] Add a dedicated Workspace filter to the Reports tab #59450

If no regressions arise, payment will be issued on 2025-04-17. 🎊

For reference, here are some details about the assignees on this issue:

• @WojtekBoman does not require payment (Contractor)
• @dukenv0307 requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@dukenv0307] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[mountiny]

No need for payment here and regression tests will be added as part of the project so we can close now

[dannymcclain]

@mountiny @WojtekBoman wasn't sure where the right place to post this was, but on the LHB beta, I just discovered that if I filter to a workspace on the Reports page, it ALSO filters my Inbox 😱 and it's very hard to get it to go back to normal.

CleanShot.2025-04-18.at.08.14.59.mp4

The only way I've been able to for real clear the filter is by resetting filters and immediately going to Troubleshoot > Clear cache and restart. I think we need to fix this ASAP because it is a Large Bummer™.

cc @Expensify/design

[WojtekBoman]

@dannymcclain You're right, but I think the best solution to fix this issue is to remove the new beta version and finally remove all code related to Workspace Switcher. We're removing the beta in this PR. Once it's merged I'll start working on erasing the Workspace Switcher

[dannymcclain]

Gotcha - thanks!

[shawnborton]

Good catch Danny!

[mountiny]

Yeah we got this one reported before, its only if you are on the beta. @sumo-slonik @WojtekBoman Can we please fix this before the beta is removed? The Reports Workspace filter should not use the WorkspaceSwitcher context and I feel like this can be separated before we remove the beta

to track this a bit more clearly I have created this issue with reproduction steps #60534

Thank y'all

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.40-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Desktop Navigation] Remove leftHandBar beta #61066

If no regressions arise, payment will be issued on 2025-05-14. 🎊

For reference, here are some details about the assignees on this issue:

• @WojtekBoman does not require payment (Contractor)
• @dukenv0307 requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@dukenv0307] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.