[Due for payment 2025-04-25] [$250] mWeb - Workspace - Back button is irresponsive after importing

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.1.20-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #57502
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mweb
App Component: Workspace Settings

Action Performed:

1. Navigate in to staging.new.expensify.com
2. Go to workspace settings > Categories.
3. Click 3-dot menu > Import spreadsheet.
4. Click Upload.
5. Select a file.
6. Map the columns and click Import.
7. Click Got it.
8. Press device back button
9. Repeat step 2 to 8 by importing members, tags, and per diem rates and notice the same issue

Expected Result:

Back button should be responsive at first

Actual Result:

Back button is irresponsive

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021905402751104321096
• Upwork Job ID: 1905402751104321096
• Last Price Increase: 2025-03-27
• Automatic offers:
• daledah | Contributor | 106774716

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mallenexpensify]

This seems like a very, very niche flow.
I commented on https://github.com/Expensify/App/pull/57502in the OP and also #56936 (comment) to ask the contributor and C+ to take a look, cc @jayeshmangwani and @Krishna2323

[jayeshmangwani]

@mallenexpensify I’m not sure if this issue is a deploy blocker, as we were aware of it during the PR testing #57502 (comment). The issue was already present before the PR, but after merging it, it has become more noticeable. Previously, pressing the back button on the mobile web browser resulted in a blank page. Now, the back button needs to be pressed twice to return to the previous page, Below, I’m attaching the current production version flow when pressing the back button after importing categories, tags, or members

XRecorder_Edited_20250328_01.mp4

[youssef-lr]

Removing blocker according to comment above.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021905402751104321096

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Back button is irresponsive

What is the root cause of that problem?

After we navigate from the confirm modal we can see it runs 2 navigates here. it leads to our navigation stacks being wrong.

App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

Lines 128 to 132 in a05d34f

	const closeImportPageAndModal = () => {
	setIsImportingCategories(false);
	closeImportPage();
	Navigation.goBack(isQuickSettingsFlow ? ROUTES.SETTINGS_CATEGORIES_ROOT.getRoute(policyID, backTo) : ROUTES.WORKSPACE_CATEGORIES.getRoute(policyID));
	};

What changes do you think we should make in order to solve the problem?

1. We should add a new prop shouldHandleNavigationBack to ConfirmModal and pass it in <Modal />

App/src/components/ConfirmModal.tsx

Lines 153 to 163 in a05d34f

	<Modal
	onClose={onCancel}
	onBackdropPress={onBackdropPress}
	isVisible={isVisible}
	shouldSetModalVisibility={shouldSetModalVisibility}
	onModalHide={onModalHide}
	type={isSmallScreenWidth ? CONST.MODAL.MODAL_TYPE.BOTTOM_DOCKED : CONST.MODAL.MODAL_TYPE.CONFIRM}
	innerContainerStyle={image ? styles.pt0 : {}}
	shouldEnableNewFocusManagement={shouldEnableNewFocusManagement}
	restoreFocusType={restoreFocusType}
	>

2. Pass shouldHandleNavigationBack as true in here

App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

Lines 155 to 163 in a05d34f

	<ConfirmModal
	isVisible={spreadsheet?.shouldFinalModalBeOpened}
	title={spreadsheet?.importFinalModal?.title ?? ''}
	prompt={spreadsheet?.importFinalModal?.prompt ?? ''}
	onConfirm={closeImportPageAndModal}
	onCancel={closeImportPageAndModal}
	confirmText={translate('common.buttonConfirm')}
	shouldShowCancelButton={false}
	/>

It'll help us to update the navigation stacks here

App/src/components/Modal/index.tsx

Lines 50 to 53 in a05d34f

	if (shouldHandleNavigationBack) {
	window.history.pushState({shouldGoBack: true}, '', null);
	window.addEventListener('popstate', handlePopStateRef.current);
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[mallenexpensify]

@RachCHopkins thanks for keeping 👀 on, I unassigned ya.

@youssef-lr eyes plz (from across the Strait of Gibraltar, I can see Morocco from my window now!)

[melvin-bot]

@youssef-lr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.29-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Workspace - Back button is irresponsive after importing #59647

If no regressions arise, payment will be issued on 2025-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @daledah requires payment automatic offer (Contributor)

[melvin-bot]

@mananjadhav @mallenexpensify @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[mananjadhav]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: daledah@e407d21#r155782747

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: NA

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Considering this is a small change of adding the prop, I think we don't need a regression test here.

[mananjadhav]

@mallenexpensify This is ready for payout.

[melvin-bot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

Contributor: @daledah paid $250 via Upwork
Contributor+: @mananjadhav due $250 via NewDot @manan

@daledah , there's a bug in Upwork and I can't pay right now, will try again later today or tomorrow, apologies for the delay

[mallenexpensify]

Was able to pay via firefox, Chrome still isn't working ¯_(ツ)_/¯

[jayeshmangwani]

Hey @mallenexpensify, just a heads-up — @mananjadhav's payment is due. I haven't reviewed the PR, so I don't have any dues.

[mallenexpensify]

ooooooof, GH being evil. Thx @jayeshmangwani , payment summary updated

[garrettmknight]

$250 approved for @mananjadhav