-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-04-08] [$250] Help Panel - the cursor is shown on unfocused composer box #59054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @RachCHopkins ( |
We can’t check Prod and I’m not sure if this issue is a DB |
The 'Help Panel' feat is not available on Prod, I don't think it's a blocker. |
Can you take a look @blazejkustra? Thanks. |
Job added to Upwork: https://www.upwork.com/jobs/~021904714082516166842 |
Current assignee @brunovjk is eligible for the External assigner, not assigning anyone new. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Help Panel - the cursor is shown on unfocused composer box What is the root cause of that problem?We don't return early in the case where both the Help Panel and a previous modal are open, which causes the composer to be focused. App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx Line 674 in e382d1b
What changes do you think we should make in order to solve the problem?To resolve this issue, we should return early when the Help Panel is open and a previous modal is still active import: const {isPaneHidden} = useSidePane(); ttps://github.com/Expensify/App/blob/e382d1b310e95fca8b0c6ce2504da1df9f432a83/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx#L674 add: if (!isPaneHidden && prevIsModalVisible) {
return;
} What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?None What alternative solutions did you explore? (Optional)Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.21-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-04-08. 🎊 For reference, here are some details about the assignees on this issue:
|
@brunovjk @RachCHopkins @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
After the regression period I believe we can close this issue, payment and BZ checklist will be handled here. Thanks! |
No payment needed here! |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v9.1.18-2
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #58847
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Other
Action Performed:
Precondition:
Run Onyx.set('nvp_sidePanel', {}) in console
Expected Result:
Cursor is not shown on unfocused compose box
Actual Result:
The cursor is shown on unfocused composer box.
Workaround:
Unknown
Platforms:
Screenshots/Videos
1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @RachCHopkinsThe text was updated successfully, but these errors were encountered: