Skip to content

[Due for payment 2025-04-08] [$250] Help Panel - the cursor is shown on unfocused composer box #59054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
jponikarchuk opened this issue Mar 25, 2025 · 15 comments
Closed
2 of 8 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@jponikarchuk
Copy link

jponikarchuk commented Mar 25, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.18-2
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #58847
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Other

Action Performed:

Precondition:

Run Onyx.set('nvp_sidePanel', {}) in console

  1. Go to staging.new.expensify.com
  2. Go to chat
  3. Open Help Panel
  4. clicking on CMD(ctrl) + D
  5. Close the testing preferences dialog

Expected Result:

Cursor is not shown on unfocused compose box

Actual Result:

The cursor is shown on unfocused composer box.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021904714082516166842
  • Upwork Job ID: 1904714082516166842
  • Last Price Increase: 2025-04-02
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @RachCHopkins
@jponikarchuk jponikarchuk added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Mar 25, 2025
Copy link

melvin-bot bot commented Mar 25, 2025

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@jponikarchuk
Copy link
Author

jponikarchuk commented Mar 25, 2025

We can’t check Prod and I’m not sure if this issue is a DB

@brunovjk
Copy link
Contributor

The 'Help Panel' feat is not available on Prod, I don't think it's a blocker.
Im the C+ for the PR. Can we assign me here? Thanks.

@brunovjk
Copy link
Contributor

Can you take a look @blazejkustra? Thanks.

@RachCHopkins RachCHopkins added the External Added to denote the issue can be worked on by a contributor label Mar 26, 2025
Copy link

melvin-bot bot commented Mar 26, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021904714082516166842

@melvin-bot melvin-bot bot changed the title Help Panel - the cursor is shown on unfocused composer box [$250] Help Panel - the cursor is shown on unfocused composer box Mar 26, 2025
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 26, 2025
Copy link

melvin-bot bot commented Mar 26, 2025

Current assignee @brunovjk is eligible for the External assigner, not assigning anyone new.

@huult
Copy link
Contributor

huult commented Mar 26, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

Help Panel - the cursor is shown on unfocused composer box

What is the root cause of that problem?

We don't return early in the case where both the Help Panel and a previous modal are open, which causes the composer to be focused.

What changes do you think we should make in order to solve the problem?

To resolve this issue, we should return early when the Help Panel is open and a previous modal is still active

import:

    const {isPaneHidden} = useSidePane();

ttps://github.com/Expensify/App/blob/e382d1b310e95fca8b0c6ce2504da1df9f432a83/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx#L674

add:

    if (!isPaneHidden && prevIsModalVisible) {
        return;
    }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 26, 2025
@blazejkustra
Copy link
Contributor

Update: I just raised a PR, @brunovjk will review it as a C+ 🥇

Copy link

melvin-bot bot commented Mar 31, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 1, 2025
@melvin-bot melvin-bot bot changed the title [$250] Help Panel - the cursor is shown on unfocused composer box [Due for payment 2025-04-08] [$250] Help Panel - the cursor is shown on unfocused composer box Apr 1, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 1, 2025
Copy link

melvin-bot bot commented Apr 1, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 1, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.21-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-08. 🎊

For reference, here are some details about the assignees on this issue:

  • @brunovjk requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Apr 1, 2025

@brunovjk @RachCHopkins @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link

melvin-bot bot commented Apr 2, 2025

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@brunovjk
Copy link
Contributor

brunovjk commented Apr 4, 2025

After the regression period I believe we can close this issue, payment and BZ checklist will be handled here. Thanks!

@RachCHopkins
Copy link
Contributor

No payment needed here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants