Skip to content

LHN - Expense sender is shown twice and LHN shows sender pays instead of the payer #58940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8 tasks done
jponikarchuk opened this issue Mar 22, 2025 · 20 comments
Closed
8 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@jponikarchuk
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.17-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. [User A] Submit an expense to User B.
  3. [User B] Open DM with User A.
  4. [User B] Note that LHN shows "You" when User A is the sender.
  5. [User B] Go to the expense report.
  6. [User B] Note that LHN shows "User A" twice in the preview.
  7. [User B] Click Pay elsewhere.
  8. [User B] Note that LHN shows "User A" pays the expense.

Expected Result:

In Step 4, LHN will show "User A" instead of "You".
In Step 6, LHN preview will show "User A" once.
In Step 8, LHN will show "User B" paid the expense.

Actual Result:

In Step 4, LHN shows "You" when User A is the sender.
In Step 6, LHN preview shows "User A" twice.
In Step 8, LHN shows that "User A" paid the expense when "User B" paid it.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

@jponikarchuk jponikarchuk added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Mar 22, 2025
Copy link

melvin-bot bot commented Mar 22, 2025

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Mar 22, 2025

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Mar 22, 2025
Copy link

melvin-bot bot commented Mar 22, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 22, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@robertjchen
Copy link
Contributor

I feel like this may be on the backend and related to issues we've seen in the past 🤔

@robertjchen robertjchen added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Mar 24, 2025
@melvin-bot melvin-bot bot added the Overdue label Mar 26, 2025
@zanyrenney
Copy link
Contributor

Should we make this internal then, @robertjchen ?

@melvin-bot melvin-bot bot removed the Overdue label Mar 26, 2025
@zanyrenney
Copy link
Contributor

Bump @robertjchen should i make this internal ?

@melvin-bot melvin-bot bot added the Overdue label Mar 31, 2025
Copy link

melvin-bot bot commented Mar 31, 2025

@robertjchen, @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@zanyrenney
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Mar 31, 2025
@tgolen tgolen moved this to HIGH in [#whatsnext] #quality Mar 31, 2025
@zanyrenney
Copy link
Contributor

This is now in HIGH so should be prioritised better, thanks Tim!

@robertjchen robertjchen added the Internal Requires API changes or must be handled by Expensify staff label Apr 2, 2025
@robertjchen
Copy link
Contributor

Tagged as Internal 👍

@zanyrenney
Copy link
Contributor

waiting for someone internal to pick it up

@zanyrenney
Copy link
Contributor

zanyrenney commented Apr 3, 2025

same as above!

Copy link

melvin-bot bot commented Apr 5, 2025

@robertjchen @zanyrenney this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Apr 7, 2025
Copy link

melvin-bot bot commented Apr 7, 2025

@robertjchen, @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot removed the Overdue label Apr 7, 2025
@zanyrenney zanyrenney added Weekly KSv2 and removed Daily KSv2 labels Apr 8, 2025
@zanyrenney
Copy link
Contributor

Chatted in Slack but downgrading this to weekly since this has been a long-standing issue and there won't be a quick resolution.

@melvin-bot melvin-bot bot added the Overdue label Apr 17, 2025
@robertjchen
Copy link
Contributor

no update

@melvin-bot melvin-bot bot removed the Overdue label Apr 28, 2025
@melvin-bot melvin-bot bot added the Overdue label May 7, 2025
@zanyrenney
Copy link
Contributor

zanyrenney commented May 13, 2025

@robertjchen what should we do here? @muttmuure mentioned this in his update.

I am not sure if you have capacity to pick it up, but perhaps if not we could get an external contributor to take a look, unless its BE?

@melvin-bot melvin-bot bot removed the Overdue label May 13, 2025
@robertjchen
Copy link
Contributor

robertjchen commented May 14, 2025

I believe this may still be hinged on the BE, but I propose that we close this out in favor of other ongoing priorities. Perhaps we can revisit if it proves to be a critical issue affecting mainline flows and stopping users from using NewDot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

3 participants