Skip to content

Distance - Error displayed after creating a distance expense offline and going online #58906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7 of 8 tasks
jponikarchuk opened this issue Mar 21, 2025 · 24 comments
Open
7 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@jponikarchuk
Copy link

jponikarchuk commented Mar 21, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.16-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5782592&group_by=cases:section_id&group_id=294997&group_order=asc
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to https://staging.new.expensify.com/ and log in as a new Gmail account
  2. Navigate to a workspace chat
  3. Disable the internet connection
  4. Click on the "+" button
  5. Select "Submit expense"
  6. Click on the "Distance" tab
  7. Click on "Start"
  8. Enter a destination - E,g "45n N Beach Rd, FL"
  9. Enter a new destination
  10. Enter the "Finish" address - e.g "Beach Access Path, Sunny Isles Beach, FL"
  11. Click on Save
  12. Click on the "Submit" button
  13. Click on the expense
  14. Enable the internet connection

Expected Result:

Verify the distance expense is not greyed out
Verify the map loads and displays the trip road
Verify the details of the miles and amount are displayed

Actual Result:

After creating a new distance expense offline and going online again, the distance expense displays an error. When clicking the "X" button on the error message, the expense disappears.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mountiny
@jponikarchuk jponikarchuk added Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Mar 21, 2025
Copy link

melvin-bot bot commented Mar 21, 2025

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@jponikarchuk
Copy link
Author

Not reproducible in Production

bandicam.2025-03-21.15-37-08-273.mp4

@isabelastisser
Copy link
Contributor

Not reproducible; closing.

@isagoico
Copy link

@isabelastisser We're able to consistently reproduce this issue ad it's not reproducible in prod. Do we still want to keep it closed?

bandicam.2025-03-21.18-33-30-134.mp4

@isabelastisser
Copy link
Contributor

Thanks for the heads up, @isagoico! Reopening it.

@melvin-bot melvin-bot bot added the Overdue label Mar 24, 2025
@Gonals Gonals added the DeployBlockerCash This issue or pull request should block deployment label Mar 24, 2025
Copy link

melvin-bot bot commented Mar 24, 2025

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 24, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 24, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Gonals
Copy link
Contributor

Gonals commented Mar 24, 2025

Can confirm this happens in staging, but not in prod. I haven't been able to reproduce in Dev, but that's likely just dev being dev

@mountiny
Copy link
Contributor

@Gonals What was the requestID or error you got in staging?

@Gonals
Copy link
Contributor

Gonals commented Mar 24, 2025

92559a0a98e4cbb3-SJC is the most recent

Extra info: If you use places you already "have" (AKA, you repeat a distance expense you already correctly created between two spots), it does not error.

@mountiny
Copy link
Contributor

I am also getting an error in production - I think the RCA is that the mapbox api fails to fetch the enriched waypoints (from offline mode the points do not have lat and lon so we have to get that

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Mar 24, 2025
@mountiny mountiny added the Internal Requires API changes or must be handled by Expensify staff label Mar 24, 2025
@mountiny
Copy link
Contributor

Seems like an issue with mapbox api - its an edge case flow though as this is only when the request was made offline and the waypoints data does not have latitude and longitude info

@mountiny
Copy link
Contributor

Havent looked yet

@melvin-bot melvin-bot bot added the Overdue label Mar 31, 2025
Copy link

melvin-bot bot commented Apr 1, 2025

@isabelastisser, @mountiny Eep! 4 days overdue now. Issues have feelings too...

@mountiny
Copy link
Contributor

mountiny commented Apr 1, 2025

This is a lower priority as its an edge case

@melvin-bot melvin-bot bot removed the Overdue label Apr 1, 2025
@isabelastisser isabelastisser added Weekly KSv2 and removed Daily KSv2 labels Apr 1, 2025
Copy link

melvin-bot bot commented Apr 4, 2025

@isabelastisser @mountiny this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@mountiny
Copy link
Contributor

mountiny commented Apr 4, 2025

focusing on higher priority task now

@isabelastisser
Copy link
Contributor

No updates!

@melvin-bot melvin-bot bot removed the Overdue label Apr 14, 2025
@mountiny
Copy link
Contributor

No updates still

@melvin-bot melvin-bot bot added the Overdue label Apr 28, 2025
@mountiny
Copy link
Contributor

Same

@melvin-bot melvin-bot bot removed the Overdue label Apr 28, 2025
@melvin-bot melvin-bot bot added the Overdue label May 7, 2025
@isabelastisser
Copy link
Contributor

No updates.

@mountiny
Copy link
Contributor

mountiny commented May 9, 2025

Back from ooo, catching up

@melvin-bot melvin-bot bot removed the Overdue label May 9, 2025
@melvin-bot melvin-bot bot added the Overdue label May 19, 2025
@mountiny
Copy link
Contributor

still low but hoping to find some time for this soon

@melvin-bot melvin-bot bot removed the Overdue label May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Status: LOW
Development

No branches or pull requests

5 participants