Skip to content

[Due for payment 2025-04-02] Help panel - Help panel opens together with attachment view #58818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
lanitochka17 opened this issue Mar 20, 2025 · 11 comments
Closed
2 of 8 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 20, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.16-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #58576
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Run Onyx.set('nvp_sidePanel', {}) in console
  1. Go to staging.new.expensify.com
  2. Go to chat
  3. Upload an image
  4. Click on the help icon
  5. Click on the image attachment

Expected Result:

Help panel will be hidden

Actual Result:

Help panel opens together with attachment view

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6777076_1742488098093.20250321_002601.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @isabelastisser
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 20, 2025
Copy link

melvin-bot bot commented Mar 20, 2025

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 20, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@pecanoro
Copy link
Contributor

Removing deploy blocker since this feature is not available to users yet,

@pecanoro pecanoro removed the DeployBlockerCash This issue or pull request should block deployment label Mar 20, 2025
@pecanoro pecanoro reopened this Mar 20, 2025
@pecanoro
Copy link
Contributor

I am going to assign the original authors of the PR so this can be handled.

@pecanoro pecanoro added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 and removed Hourly KSv2 labels Mar 20, 2025
Copy link

melvin-bot bot commented Mar 20, 2025

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@blazejkustra
Copy link
Contributor

This is fixed in this PR @brunovjk

@pecanoro pecanoro added the Reviewing Has a PR in review label Mar 21, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Mar 26, 2025
@melvin-bot melvin-bot bot changed the title Help panel - Help panel opens together with attachment view [Due for payment 2025-04-02] Help panel - Help panel opens together with attachment view Mar 26, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 26, 2025
Copy link

melvin-bot bot commented Mar 26, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 26, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.18-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-02. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Mar 26, 2025

@brunovjk @isabelastisser @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@pecanoro
Copy link
Contributor

I am going to close this issue since this is being handled as part of a bigger project. Please, correct me if I am wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants