Skip to content

[Due for payment 2025-04-10] [Better Expense Report View] iOS - Reports - Report view is blank and does not show skeleton when fetching data #58813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
lanitochka17 opened this issue Mar 20, 2025 · 9 comments · Fixed by #58903
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 20, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.16-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Log in with Expensifail account
  • Account has some expenses
  • Perform a fresh log in so that those expense reports are not opened yet
  1. Launch ND or hybrid app
  2. Go to Reports
  3. Tap bookmark icon
  4. Tap Expense Reports
  5. Open any expense report

Expected Result:

Report will show skeleton when fetching data

Actual Result:

Report is blank while fetching data

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6777042_1742486137686.ScreenRecording_03-20-2025_23-52-47_1.1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @Kicu
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 20, 2025
Copy link

melvin-bot bot commented Mar 20, 2025

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 20, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@luacmartins
Copy link
Contributor

This view is behind a beta. NAB. cc @Kicu

@luacmartins luacmartins added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Mar 20, 2025
@mountiny mountiny self-assigned this Mar 21, 2025
@mountiny mountiny moved this to Second Cohort - CRITICAL in [#whatsnext] #migrate Mar 21, 2025
@mountiny mountiny changed the title iOS - Reports - Report view is blank and does not show skeleton when fetching data [Better Expense Report View] iOS - Reports - Report view is blank and does not show skeleton when fetching data Mar 21, 2025
Copy link

melvin-bot bot commented Mar 25, 2025

@Kicu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Mar 25, 2025
@Kicu
Copy link
Member

Kicu commented Mar 26, 2025

will be fixed in #58903 - I'm adding skeleton preview there when data is loading

@melvin-bot melvin-bot bot removed the Overdue label Mar 26, 2025
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 27, 2025
@github-project-automation github-project-automation bot moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrate Mar 31, 2025
Copy link

melvin-bot bot commented Apr 1, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 3, 2025
@melvin-bot melvin-bot bot changed the title [Better Expense Report View] iOS - Reports - Report view is blank and does not show skeleton when fetching data [Due for payment 2025-04-10] [Better Expense Report View] iOS - Reports - Report view is blank and does not show skeleton when fetching data Apr 3, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 3, 2025
Copy link

melvin-bot bot commented Apr 3, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 3, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.22-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-10. 🎊

For reference, here are some details about the assignees on this issue:

  • @Kicu does not require payment (Contractor)
  • @DylanDylann requires payment (Needs manual offer from BZ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
Development

Successfully merging a pull request may close this issue.

6 participants