[Due for payment 2025-04-14] Search - Unable to perform search via CMD+K

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.15-3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

1. Go to staging.new.expensify.com
2. Open search router via CMD+K.
3. Type anything.
4. Hit Enter.

Expected Result:

Reports page will open and show search results.

Actual Result:

App stays in Inbox.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021902402444813986614
• Upwork Job ID: 1902402444813986614
• Last Price Increase: 2025-03-19

Issue Owner

Current Issue Owner: @lydiabarclay

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[vincdargento]

@lydiabarclay FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021902402444813986614

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[lydiabarclay]

I was able to reproduce this on staging, as well as some related unexpected behavior (vid below).

1. Searched for keyword "hello", reports tab did not open.
2. Then clicked on Reports tab, and found that a filter for my keyword "hello" had been applied, despite the tab not opening.
3. Reproduced that same pattern again for a second keyword "flower."
4. Reset filters.
5. Searched for a third keyword "tasty."
6. This time the Reports tab did open, but filtered for the second keyword "flower" again

2025-03-19_09-46-44.mp4

[lydiabarclay]

Not reproducible on production

2025-03-19_09-59-23.1.mp4

[flodnv]

I'm also able to reproduce on staging but not on production

[flodnv]

This seems related with #58742, cc @MarioExpensify

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App stays in Inbox.

What is the root cause of that problem?

When we submit the search query using the enter key, both onListItemPress and onSubmit are triggered.

App/src/components/Search/SearchRouter/SearchRouter.tsx

Line 240 in 4fe6c49

const onListItemPress = useCallback(

App/src/components/Search/SearchRouter/SearchRouter.tsx

Line 325 in 4fe6c49

onSubmit={() => {

onListItemPress is triggered first, after that we navigate to the search page, the search router isn't displayed, and getAdditionalSections returns undefined.

App/src/components/Search/SearchRouter/SearchRouter.tsx

Lines 116 to 118 in 4fe6c49

	if (!isSearchRouterDisplayed) {
	return undefined;
	}

After that the onSubmit is triggered, at this time focusedOption is the last access report because the additionalSections now is undefined, and then we navigate to the report screen again.

App/src/components/Search/SearchRouter/SearchRouter.tsx

Lines 326 to 330 in 4fe6c49

	const focusedOption = listRef.current?.getFocusedOption();
	if (!focusedOption) {
	submitSearch(textInputValue);
	return;

What changes do you think we should make in order to solve the problem?

We should return early if the search router isn't displayed here

if (!isSearchRouterDisplayed) {
    return;
}

App/src/components/Search/SearchRouter/SearchRouter.tsx

Lines 326 to 330 in 4fe6c49

	const focusedOption = listRef.current?.getFocusedOption();
	if (!focusedOption) {
	submitSearch(textInputValue);
	return;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[luacmartins]

We're reverting the offending PR #58083

[luacmartins]

This is fixed in staging.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "fix: Tapping an item from recent list directs blank page in mWeb & LHN in Android briefly" #58754

If no regressions arise, payment will be issued on 2025-03-27. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment through NewDot Manual Requests

[melvin-bot]

@hoangzinh @lydiabarclay @hoangzinh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[lydiabarclay]

well done everyone! no payment is due here as it was a straight revert

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Tapping an item from recent list directs blank page #58878

If no regressions arise, payment will be issued on 2025-04-14. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment through NewDot Manual Requests

[melvin-bot]

@hoangzinh @lydiabarclay @hoangzinh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[lydiabarclay]

no payment is due here as it was a straight revert