Skip to content

[Due for payment 2025-03-25] [Due for payment 2025-03-24] Android - Wallet - Save & continue button is hidden behind device navigation bar #58500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
IuliiaHerets opened this issue Mar 14, 2025 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Mar 14, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.13-2
Reproducible in staging?: Yes
Reproducible in production?: Cannot check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: User Settings

Action Performed:

Precondition:

  • Device navigation is navigation bar instead of gesture
  1. Launch ND or hybrid app.
  2. Go to Settings > Wallet.
  3. Tap Add bank account.
  4. Select United States > Next.
  5. Add Wells Fargo account.
  6. Land in bank account selection page.

Expected Result:

Save & continue button is above device navigation bar.

Actual Result:

Save & continue button is hidden behind device navigation bar.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6770727_1741965876664.Screen_Recording_20250314_232008_New_Expensify.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @JmillsExpensify
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Mar 14, 2025
Copy link

melvin-bot bot commented Mar 14, 2025

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Mar 14, 2025

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 14, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 14, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@chrispader
Copy link
Contributor

Should be fixed by #58481

cc @mountiny

Copy link

melvin-bot bot commented Mar 14, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API Hourly KSv2 labels Mar 14, 2025
@mountiny
Copy link
Contributor

No need for payment and fix was CPed

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Mar 17, 2025
@melvin-bot melvin-bot bot changed the title Android - Wallet - Save & continue button is hidden behind device navigation bar [Due for payment 2025-03-24] Android - Wallet - Save & continue button is hidden behind device navigation bar Mar 17, 2025
Copy link

melvin-bot bot commented Mar 17, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-03-24. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Mar 17, 2025

@tylerkaraszewski / @mountiny @JmillsExpensify @chrispader The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Mar 17, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-03-24] Android - Wallet - Save & continue button is hidden behind device navigation bar [Due for payment 2025-03-25] [Due for payment 2025-03-24] Android - Wallet - Save & continue button is hidden behind device navigation bar Mar 18, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 18, 2025
Copy link

melvin-bot bot commented Mar 18, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 18, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.14-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-03-25. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Mar 18, 2025

@tylerkaraszewski / @mountiny @JmillsExpensify @chrispader The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants