-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-03-25] [$250] Create Expense - The app does not scroll to the bottom when a new expense is created. #58455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @madmax330 ( |
Triggered auto assignment to @greg-schroeder ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Job added to Upwork: https://www.upwork.com/jobs/~021900480710794741851 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 ( |
Offending PR #57901 should we revert it rather than fix it? @madmax330 @c3024 |
ProposalPlease re-state the problem that we are trying to solve in this issue.Create Expense - The app does not scroll to the bottom when a new expense is created What is the root cause of that problem?Offending PR #57901 What changes do you think we should make in order to solve the problem?I think we should revert the offending PR What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?N/A What alternative solutions did you explore? (Optional)Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
I am checking |
@rojiphil I guess the case of this issue is different from ours, and they did not call onLayout. So, I think we should call reportScrollManager.scrollToBottom(); and add it back. |
I agree. Can you please raise a quick PR for this as this is a small change? |
yes |
Please tag me once the PR is ready and I will review the same as this is caused by our PR. |
yes I will open the pr within an hour |
@rojiphil The PR is ready |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-03-24. 🎊 For reference, here are some details about the assignees on this issue:
|
@rojiphil / @c3024 @greg-schroeder @rojiphil / @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.14-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-03-25. 🎊 For reference, here are some details about the assignees on this issue:
|
@rojiphil / @c3024 @greg-schroeder @rojiphil / @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Processing today |
@greg-schroeder Let us close this out as this was fixed as part of the regression fix. No payment is due to anyone here. |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.13-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5741323
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Web, mweb
App Component: Chat Report View
Action Performed:
Expected Result:
When a new expense is created, the app should automatically scroll to the bottom.
Actual Result:
The app does not scroll to the bottom when a new expense is created
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6770398_1741934366298.bandicam_2025-03-14_09-33-13-118.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @greg-schroederThe text was updated successfully, but these errors were encountered: