Skip to content

[Due for payment 2025-03-25] [$250] Create Expense - The app does not scroll to the bottom when a new expense is created. #58455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
mitarachim opened this issue Mar 14, 2025 · 25 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@mitarachim
Copy link

mitarachim commented Mar 14, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.13-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5741323
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Web, mweb
App Component: Chat Report View

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Go to any chat
  3. scroll up until the latest comment is out of view.
  4. Create an expense

Expected Result:

When a new expense is created, the app should automatically scroll to the bottom.

Actual Result:

The app does not scroll to the bottom when a new expense is created

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6770398_1741934366298.bandicam_2025-03-14_09-33-13-118.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021900480710794741851
  • Upwork Job ID: 1900480710794741851
  • Last Price Increase: 2025-03-14
  • Automatic offers:
    • huult | Contributor | 106523351
Issue OwnerCurrent Issue Owner: @greg-schroeder
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Mar 14, 2025
Copy link

melvin-bot bot commented Mar 14, 2025

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 14, 2025

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Mar 14, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 14, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@madmax330 madmax330 added the External Added to denote the issue can be worked on by a contributor label Mar 14, 2025
Copy link

melvin-bot bot commented Mar 14, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021900480710794741851

@melvin-bot melvin-bot bot changed the title Create Expense - The app does not scroll to the bottom when a new expense is created. [$250] Create Expense - The app does not scroll to the bottom when a new expense is created. Mar 14, 2025
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 14, 2025
Copy link

melvin-bot bot commented Mar 14, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

@linhvovan29546
Copy link
Contributor

Offending PR #57901 should we revert it rather than fix it? @madmax330 @c3024

@linhvovan29546
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Create Expense - The app does not scroll to the bottom when a new expense is created

What is the root cause of that problem?

Offending PR #57901

What changes do you think we should make in order to solve the problem?

I think we should revert the offending PR

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@huult
Copy link
Contributor

huult commented Mar 14, 2025

I am checking

@rojiphil
Copy link
Contributor

@huult Please check if we need to still call reportScrollManager.scrollToBottom(); here to scroll down along with setIsScrollToBottomEnabled. We had removed it at a later stage

@huult
Copy link
Contributor

huult commented Mar 14, 2025

@rojiphil I guess the case of this issue is different from ours, and they did not call onLayout. So, I think we should call reportScrollManager.scrollToBottom(); and add it back.

@rojiphil
Copy link
Contributor

rojiphil commented Mar 14, 2025

I guess the case of this issue is different from ours, and they did not call onLayout. So, I think we should call reportScrollManager.scrollToBottom(); and add it back.

I agree. Can you please raise a quick PR for this as this is a small change?

@huult
Copy link
Contributor

huult commented Mar 14, 2025

yes

@rojiphil
Copy link
Contributor

Please tag me once the PR is ready and I will review the same as this is caused by our PR.

@huult
Copy link
Contributor

huult commented Mar 14, 2025

yes I will open the pr within an hour

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Mar 14, 2025
@huult
Copy link
Contributor

huult commented Mar 14, 2025

@rojiphil The PR is ready

@mountiny mountiny removed DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Mar 14, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 17, 2025
@melvin-bot melvin-bot bot changed the title [$250] Create Expense - The app does not scroll to the bottom when a new expense is created. [Due for payment 2025-03-24] [$250] Create Expense - The app does not scroll to the bottom when a new expense is created. Mar 17, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 17, 2025
Copy link

melvin-bot bot commented Mar 17, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 17, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-03-24. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Mar 17, 2025

@rojiphil / @c3024 @greg-schroeder @rojiphil / @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Mar 18, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-03-24] [$250] Create Expense - The app does not scroll to the bottom when a new expense is created. [Due for payment 2025-03-25] [Due for payment 2025-03-24] [$250] Create Expense - The app does not scroll to the bottom when a new expense is created. Mar 18, 2025
Copy link

melvin-bot bot commented Mar 18, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.14-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-03-25. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Mar 18, 2025

@rojiphil / @c3024 @greg-schroeder @rojiphil / @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@greg-schroeder greg-schroeder changed the title [Due for payment 2025-03-25] [Due for payment 2025-03-24] [$250] Create Expense - The app does not scroll to the bottom when a new expense is created. [Due for payment 2025-03-25] [$250] Create Expense - The app does not scroll to the bottom when a new expense is created. Mar 19, 2025
@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Mar 24, 2025
@greg-schroeder
Copy link
Contributor

Processing today

@melvin-bot melvin-bot bot removed the Overdue label Mar 26, 2025
@rojiphil
Copy link
Contributor

@greg-schroeder Let us close this out as this was fixed as part of the regression fix. No payment is due to anyone here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
Status: Done
Development

No branches or pull requests

8 participants