[Report Creation UI] Create report - No workspace selection screen when creating a new report

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.13-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #57847
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• User has more than one workspace

1. Go to staging.new.expensify.com
2. Go to FAB > Create report.

Expected Result:

App will open workspace selection screen.

Actual Result:

There is no workspace selection screen when creating a new report.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6770231_1741919629308.20250314_103115.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021900466160745777243
• Upwork Job ID: 1900466160745777243
• Last Price Increase: 2025-03-14
• Automatic offers:
• DylanDylann | Reviewer | 106524191

Issue Owner

Current Issue Owner: @DylanDylann

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no workspace selection screen when creating a new report.

What is the root cause of that problem?

I'm not sure about OD but in ND this condition is always true:

App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

Lines 494 to 498 in ba6abb8

	if (activePolicy && activePolicy.isPolicyExpenseChatEnabled && isPaidGroupPolicy(activePolicy)) {
	const createdReportID = createNewReport(currentUserPersonalDetails, activePolicyID);
	Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: createdReportID, backTo: Navigation.getActiveRoute()}));
	return;
	}

So the lower logics is not triggered at all

What changes do you think we should make in order to solve the problem?

We should move "multi workspace" condition to above this condition

App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

Lines 494 to 498 in ba6abb8

	if (activePolicy && activePolicy.isPolicyExpenseChatEnabled && isPaidGroupPolicy(activePolicy)) {
	const createdReportID = createNewReport(currentUserPersonalDetails, activePolicyID);
	Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: createdReportID, backTo: Navigation.getActiveRoute()}));
	return;
	}

if (groupPoliciesWithChatEnabled.length > 1) {
        Navigation.navigate(ROUTES.NEW_REPORT_WORKSPACE_SELECTION);
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[daledah]

Offending PR but I can help raise a quick fix if needed. Also the feature's behind beta so I think it's not a blocker.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021900466160745777243

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[SzymczakJ]

This is intended logic. I made a mistake in test steps, which I corrected now.
Here's how it works:

1. We redirect to Old Dot when user haas no paid group workspace with chat enabled.
2. We automatically create a report(without redirecting to workspace selection) when user:

• has a default workspace which is a paid group workspace with chat enabled(we use it for creation)
• has only one paid group workspace with chat enabled, then we use it for creation, even if it's not set as default

3. We redirect user to workspace selection page, when user's default workspace is set to the personal workspace
   and user also has multiple group workspaces, so we can't "guess" which one to use.

So reassuming, if your Applause workspace is a paid group workspace with chat enabled, then we use it by default and create a report without showing selection page. Sorry for messing up the test steps in the first place.

This can be closed.

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[mountiny]

@trjExpensify can you please confirm this is intended and close if so. From what @SzymczakJ wrote I agree

[trjExpensify]

Yep, agreed.

We redirect to Old Dot when user haas no paid group workspace with chat enabled.

Assuming this meant "we show the switch to classic modal if the user only has paid group workspaces that don’t have chat enabled", which is existing logic we haven't touched.

Sidebar: I take it Applause is seeing this because they're on the beta? 😅

[mountiny]

Sidebar: I take it Applause is seeing this because they're on the beta? 😅

yes