[$250] [Due for payment 2025-03-21] Android - Workflows - Device back gesture on Workflows page directly returns to Workspace list #57997

mitarachim · 2025-03-07T09:17:31Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.1.10-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Workspace Settings

Action Performed:

Launch ND or hybrid app.
Go to Workspace settings.
Go to Workflows.
Use device back button or device back gesture to go back.

Expected Result:

App will return to workspace editor.

Actual Result:

App returns two steps back to workspace list.

This issue also happens in Rules and Report fields page, and is not reproducible on Members and Categories page.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6763758_1741337961965.1741337822782_Screen_Recording_20250307_165630_New_Expensify.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021903098363836892744
Upwork Job ID: 1903098363836892744
Last Price Increase: 2025-03-21
Automatic offers:

daledah | Contributor | 106616351

melvin-bot · 2025-03-07T09:17:40Z

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot · 2025-03-07T09:17:41Z

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot · 2025-03-07T09:17:42Z

💬 A slack conversation has been started in #expensify-open-source

github-actions · 2025-03-07T09:17:48Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

nkdengineer · 2025-03-07T09:29:47Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

App returns two steps back to workspace list.

What is the root cause of that problem?

when we press the device back button we are using the goBack function here

App/src/pages/workspace/WorkspacePageWithSections.tsx

Line 187 in c7aa2c1

    
           onBackButtonPress={() => (onBackButtonPress ? onBackButtonPress() : Navigation.goBack(backButtonRoute))}

What changes do you think we should make in order to solve the problem?

We should use hook useHandleBackButton like we did with WorkspaceListPage here

   const goBack = () => {
        if(!!onBackButtonPress){
            onBackButtonPress();
        } else {
            Navigation.goBack(backButtonRoute);
        }
        return true;
    }
    useHandleBackButton(goBack);

And update the onBackButtonPress in HeaderWithBackButton to goBack function

      onBackButtonPress={goBack}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

cristipaval · 2025-03-07T11:27:07Z

I suspect this is the offending PR. Looking 👀

cristipaval · 2025-03-07T11:58:36Z

Demoting this one. We're discussing about a good fix here

IuliiaHerets · 2025-03-07T16:27:32Z

@cristipaval @johncschuster @nkuoch QA team found the similar issue. Is it the same root or we need to open a new one?

Version Number: 9.1.10-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy S10 5G - Android 12
App Component: Workspace Settings

Action Performed:

Open Hybrid android app
Create WS and enable tag
Navigate to tag page and click add tag
Click device back button and notice it navigates to workspace setting rather than tag list page
Navigate to tag page and click setting
Click device back button and notice it navigates to workspace setting rather than tag list page
Navigate to tag page and click 3 dot
Choose Import spreadsheet
Click device back button and notice it navigates to workspace setting rather than tag list page
Repeat step 3 to step 9 for category and notice every step leads to workspace setting rather than category list page

Expected Result:

Device back buttons leads to category or tag list rather than the main workspace setting

Actual Result:

Device back button leads to workspace setting rather than category or tag list

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6764014_1741354965194.B3.mp4

View all open jobs on GitHub

cristipaval · 2025-03-07T19:20:31Z

I suspect this is the offending PR. Looking 👀

I can confirm the offending PR. I reproduced the current issue locally, reverted the above PR, and that fixed the issue.

cristipaval · 2025-03-07T19:30:03Z

@IuliiaHerets, let's not create other issues. All Workspace Settings pages that go back to the workspace list when hitting the hardware back button on Android have the same root cause.

melvin-bot · 2025-03-14T01:21:30Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2025-03-14T01:21:37Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.12-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: migrate useHandleBackButton to @hooks and fix regressions #58049

If no regressions arise, payment will be issued on 2025-03-21. 🎊

For reference, here are some details about the assignees on this issue:

@Ollyws requires payment through NewDot Manual Requests
@daledah requires payment (Needs manual offer from BZ)

melvin-bot · 2025-03-14T01:21:38Z

@Ollyws @johncschuster @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

johncschuster · 2025-03-14T11:48:33Z

melvin-bot · 2025-03-21T08:11:02Z

Payment Summary

Upwork Job

Reviewer: @Ollyws owed $250 via NewDot
ROLE: @daledah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@johncschuster)

I have verified the correct assignees and roles are listed above and updated the necessary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

melvin-bot · 2025-03-21T14:56:24Z

Job added to Upwork: https://www.upwork.com/jobs/~021903098363836892744

melvin-bot · 2025-03-21T14:56:28Z

Current assignee @Ollyws is eligible for the External assigner, not assigning anyone new.

johncschuster · 2025-03-21T14:56:40Z

Applying the External label to see if we can auto-invite @daledah to the Upwork Job

melvin-bot · 2025-03-21T14:57:16Z

📣 @daledah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

johncschuster · 2025-03-21T14:59:05Z

Payment Summary

Contributor: @daledah paid $250 via Upwork ✅
Contributor+: @Ollyws owed $250 via NewDot ✅

@daledah, can you accept the invite to the job? I'll issue payment once that's accepted.
@Ollyws can you complete the BZ Checklist above? Once done, please request payment via ND!

daledah · 2025-03-21T15:36:01Z

@daledah, can you accept the invite to the job?

@johncschuster Done, thank you

johncschuster · 2025-03-24T12:42:21Z

Thanks, @daledah! I've issued payment to you 👍

Ollyws · 2025-03-24T13:04:45Z

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on both staging and production
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: This was a problem with the hook but only manifested when used in fix: correct back button in workspace list page #57237, which this PR was a follow-up to.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Precondition:

Test:

Test #1

1. Submit an expense to any user
2. Go to Search
3. Long press on the expense
4. Tap Select
5. Tap Back button on the top left
6. Note that only the selection mode is dismissed and app remains on the same page
7. Tap Select
8. Go back using device navigation
9. Verify that: App will dimiss the selection mode and remains on the same page

Test #2

1. Go to settings -> workspaces
2. Open/create a workspace
3. Open a workspace
4. Open any workspace tab
5. Press hardware/browser back button
6. Verify that: App redirect correctly back to Workspace list page

Do we agree 👍 or 👎

Ollyws · 2025-03-24T13:05:16Z

Requested on ND.

garrettmknight · 2025-03-24T16:21:54Z

$250 approved for @Ollyws

mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Mar 7, 2025

melvin-bot bot assigned johncschuster Mar 7, 2025

melvin-bot bot assigned nkuoch Mar 7, 2025

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 7, 2025

mitarachim changed the title ~~ndroid - Workflows - Device back gesture on Workflows page directly returns to Workspace list~~ Android - Workflows - Device back gesture on Workflows page directly returns to Workspace list Mar 7, 2025

github-actions bot mentioned this issue Mar 7, 2025

Deploy Checklist: New Expensify 2025-03-06 #57963

Closed

93 tasks

melvin-bot bot mentioned this issue Mar 7, 2025

[Due for payment 2025-03-17] [$250] When going to workspace list from Subscription, back button returns to Account settings #56997

Closed

8 tasks

cristipaval self-assigned this Mar 7, 2025

cristipaval added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API Hourly KSv2 labels Mar 7, 2025

melvin-bot bot added the Overdue label Mar 10, 2025

cristipaval assigned nkdengineer Mar 10, 2025

melvin-bot bot removed the Overdue label Mar 10, 2025

melvin-bot bot changed the title ~~Android - Workflows - Device back gesture on Workflows page directly returns to Workspace list~~ [Due for payment 2025-03-21] Android - Workflows - Device back gesture on Workflows page directly returns to Workspace list Mar 14, 2025

melvin-bot bot removed the Reviewing Has a PR in review label Mar 14, 2025

melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Mar 20, 2025

johncschuster added the External Added to denote the issue can be worked on by a contributor label Mar 21, 2025

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 21, 2025

melvin-bot bot removed the Overdue label Mar 21, 2025

johncschuster assigned daledah and unassigned daledah Mar 21, 2025

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 21, 2025

melvin-bot bot added the Overdue label Mar 24, 2025

melvin-bot bot removed the Overdue label Mar 24, 2025

johncschuster closed this as completed Mar 25, 2025

[$250] [Due for payment 2025-03-21] Android - Workflows - Device back gesture on Workflows page directly returns to Workspace list #57997

[$250] [Due for payment 2025-03-21] Android - Workflows - Device back gesture on Workflows page directly returns to Workspace list #57997

Comments

mitarachim commented Mar 7, 2025 • edited by melvin-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Mar 7, 2025

Uh oh!

melvin-bot bot commented Mar 7, 2025

Uh oh!

melvin-bot bot commented Mar 7, 2025

Uh oh!

github-actions bot commented Mar 7, 2025

Uh oh!

nkdengineer commented Mar 7, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Uh oh!

cristipaval commented Mar 7, 2025

Uh oh!

cristipaval commented Mar 7, 2025

Uh oh!

IuliiaHerets commented Mar 7, 2025

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Uh oh!

cristipaval commented Mar 7, 2025

Uh oh!

cristipaval commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot bot commented Mar 14, 2025

Uh oh!

melvin-bot bot commented Mar 14, 2025

Uh oh!

melvin-bot bot commented Mar 14, 2025

Uh oh!

johncschuster commented Mar 14, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Uh oh!

melvin-bot bot commented Mar 21, 2025

Payment Summary

BugZero Checklist (@johncschuster)

Uh oh!

melvin-bot bot commented Mar 21, 2025

Uh oh!

melvin-bot bot commented Mar 21, 2025

Uh oh!

johncschuster commented Mar 21, 2025

Uh oh!

melvin-bot bot commented Mar 21, 2025

Uh oh!

johncschuster commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Payment Summary

Uh oh!

daledah commented Mar 21, 2025

Uh oh!

johncschuster commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ollyws commented Mar 24, 2025

BugZero Checklist:

Regression Test Proposal

mitarachim commented Mar 7, 2025 •

edited by melvin-bot bot

Loading

cristipaval commented Mar 7, 2025 •

edited

Loading

johncschuster commented Mar 21, 2025 •

edited

Loading

johncschuster commented Mar 24, 2025 •

edited

Loading