-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[$250] [Due for payment 2025-03-21] Android - Workflows - Device back gesture on Workflows page directly returns to Workspace list #57997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @johncschuster ( |
Triggered auto assignment to @nkuoch ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
ProposalPlease re-state the problem that we are trying to solve in this issue.App returns two steps back to workspace list. What is the root cause of that problem?when we press the device back button we are using the
What changes do you think we should make in order to solve the problem?We should use hook
And update the
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?None What alternative solutions did you explore? (Optional)NA Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
I suspect this is the offending PR. Looking 👀 |
Demoting this one. We're discussing about a good fix here |
@cristipaval @johncschuster @nkuoch QA team found the similar issue. Is it the same root or we need to open a new one? Version Number: 9.1.10-0 Action Performed:
Expected Result:Device back buttons leads to category or tag list rather than the main workspace setting Actual Result:Device back button leads to workspace setting rather than category or tag list Workaround:Unknown Platforms:
Screenshots/VideosBug6764014_1741354965194.B3.mp4 |
I can confirm the offending PR. I reproduced the current issue locally, reverted the above PR, and that fixed the issue. |
@IuliiaHerets, let's not create other issues. All Workspace Settings pages that go back to the workspace list when hitting the hardware back button on Android have the same root cause. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.12-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-03-21. 🎊 For reference, here are some details about the assignees on this issue: |
@Ollyws @johncschuster @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
BugZero Checklist:
Bug classificationSource of bug:
Where bug was reported:
Who reported the bug:
Regression Test Proposal Template
Regression Test ProposalPrecondition:Test:Do we agree 👍 or 👎 |
Payment SummaryBugZero Checklist (@johncschuster)
|
Job added to Upwork: https://www.upwork.com/jobs/~021903098363836892744 |
Current assignee @Ollyws is eligible for the External assigner, not assigning anyone new. |
Applying the External label to see if we can auto-invite @daledah to the Upwork Job |
📣 @daledah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@johncschuster Done, thank you |
Thanks, @daledah! I've issued payment to you 👍 |
BugZero Checklist:
Bug classificationSource of bug:
Where bug was reported:
Who reported the bug:
Regression Test ProposalPrecondition:Test:
Do we agree 👍 or 👎 |
Requested on ND. |
$250 approved for @Ollyws |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.10-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Workspace Settings
Action Performed:
Expected Result:
App will return to workspace editor.
Actual Result:
App returns two steps back to workspace list.
This issue also happens in Rules and Report fields page, and is not reproducible on Members and Categories page.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6763758_1741337961965.1741337822782_Screen_Recording_20250307_165630_New_Expensify.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: