-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-03-21] [Due for payment 2025-03-17] [$250] iOS - Reports - App crashes after deleting workspace when it is selected in workspace switcher #57984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @Beamanator ( |
💬 A slack conversation has been started in #expensify-open-source |
Triggered auto assignment to @adelekennedy ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
ProposalPlease re-state the problem that we are trying to solve in this issue.App crashes. What is the root cause of that problem?We have 2 problems here
App/src/pages/workspace/WorkspacesListPage.tsx Lines 160 to 163 in c7aa2c1
App/src/pages/Search/SearchPage.tsx Line 84 in c7aa2c1
What changes do you think we should make in order to solve the problem?
App/src/pages/Search/SearchPage.tsx Line 84 in c7aa2c1
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?None What alternative solutions did you explore? (Optional)Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
@Beamanator I can help take a quick PR if needed. |
Thanks @nkdengineer please do submit a PR 🙏 |
Job added to Upwork: https://www.upwork.com/jobs/~021897966159811981264 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-d ( |
@allgandalf is going to check this out too, to see if it relates to the |
@nkdengineer - I believe we still need to use Did you determine why |
thanks @rayane-d. I'm checking now |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.10-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-03-17. 🎊 For reference, here are some details about the assignees on this issue:
|
@rayane-d @adelekennedy @rayane-d The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
This comment has been minimized.
This comment has been minimized.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.12-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-03-21. 🎊 For reference, here are some details about the assignees on this issue:
|
@rayane-d @adelekennedy @rayane-d The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
BugZero Checklist:
Bug classificationSource of bug:
Where bug was reported:
Who reported the bug:
Regression Test ProposalPrecondition:
Test:
Do we agree 👍 or 👎 |
@adelekennedy Could you please post a payment summary? Thanks |
Contributor+: @rayane-d owed $250 via NewDot |
Payment Summary
BugZero Checklist (@adelekennedy)
|
@nkdengineer bump to accept the offer in Upwork! |
@adelekennedy Accepted, ty! |
all set here |
$250 approved for @rayane-d |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.10-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search
Action Performed:
Precondition:
Expected Result:
App will not crash.
Actual Result:
App crashes.
On web, the deleted workspace remains selected in the workspace switcher when going back to Reports after deleting the workspace.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6763672_1741330652459.ScreenRecording_03-07-2025_14-54-42_1.mp4
Bug6763672_1741330781766!Expensify-2025-03-07-145452.txt
Bug6763672_1741331098195.web.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @adelekennedyThe text was updated successfully, but these errors were encountered: