Skip to content

[Due for payment 2025-03-17] Update verifyHybridApp workflow message to mention HybridApp repo patches check #57884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mountiny opened this issue Mar 5, 2025 · 6 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Mar 5, 2025

Proposal: Update verifyHybridApp workflow message to mention HybridApp repo patches check

Background

For every E/App PR that is created from a fork and updates native code and/or dependencies the verifyHybridApp workflow triggers a warning to be shown:

⚠️ This PR is possibly changing native code, it may cause problems with HybridApp. Please run an AdHoc build to verify that HybridApp will not break.⚠️

Problem

When developers update dependencies in E/App, they may modify a library patched in the HybridApp repository.
It can lead to compatibility issues, which prevent the app from functioning correctly. Developers are not automatically alerted to this risk, which can lead to unnoticed breakages.

Solution

Update the warning message triggered by the verifyHybridApp workflow to ask the developer to check if patches inside the HybridApp repo need to be updated.

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break.⚠️

Issue OwnerCurrent Issue Owner: @isabelastisser
@mountiny mountiny added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Mar 5, 2025
Copy link

melvin-bot bot commented Mar 5, 2025

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@VickyStash
Copy link
Contributor

The PR has been opened for the review!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 10, 2025
@melvin-bot melvin-bot bot changed the title Update verifyHybridApp workflow message to mention HybridApp repo patches check [Due for payment 2025-03-17] Update verifyHybridApp workflow message to mention HybridApp repo patches check Mar 10, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 10, 2025
Copy link

melvin-bot bot commented Mar 10, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 10, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.10-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-03-17. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Mar 10, 2025

@mountiny @isabelastisser @VickyStash The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
Copy link
Contributor Author

No need for checklists or payments, this was just DX improvement

@github-project-automation github-project-automation bot moved this from MEDIUM to Done in [#whatsnext] #quality Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

3 participants