Skip to content

Android Hybrid-Attachment- It is hard to scroll the pdf file #57823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 8 tasks
mitarachim opened this issue Mar 5, 2025 · 16 comments
Closed
1 of 8 tasks

Android Hybrid-Attachment- It is hard to scroll the pdf file #57823

mitarachim opened this issue Mar 5, 2025 · 16 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@mitarachim
Copy link

mitarachim commented Mar 5, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.9-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #57185
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: SS S20 FE/ Android 13
App Component: Other

Action Performed:

  1. Open Expensify hybrid app
  2. Tap on any conversation
  3. Tap on pdf preview
  4. Scroll to see more

Expected Result:

The user can easily scroll up and down through the PDF file

Actual Result:

The user swipes multiple times, but the PDF page does not change, it just moves a little

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6761506_1741151315455.az_recorder_20250305_115949.mp4

View all open jobs on GitHub

@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Mar 5, 2025
Copy link

melvin-bot bot commented Mar 5, 2025

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@trjExpensify
Copy link
Contributor

Reproducible in staging?: Yes
Reproducible in production?: No

@mitarachim is this staging repro only?

@mitarachim
Copy link
Author

Hello @trjExpensify , yes only in staging.
works as expected in Prod build 9.1.6.0

2025-03-05.9.43.34.PM.mp4

reproducible in Staging build

2025-03-05.9.43.39.PM.mp4

@mitarachim mitarachim added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Mar 5, 2025
Copy link

melvin-bot bot commented Mar 5, 2025

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 5, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 5, 2025
Copy link
Contributor

github-actions bot commented Mar 5, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@NikkiWines
Copy link
Contributor

@mitarachim can you include the PDF used for testing purposes here please 🙇

@NikkiWines
Copy link
Contributor

NikkiWines commented Mar 5, 2025

Not tagging yet as unconfirmed as the issue, but I'd guess 57185 is probably the culprit for this

@mitarachim
Copy link
Author

@NikkiWines I reproduce issue using this PDF

LARGE_PDF_FILE.pdf

@iwiznia iwiznia removed the DeployBlocker Indicates it should block deploying the API label Mar 5, 2025
@iwiznia
Copy link
Contributor

iwiznia commented Mar 5, 2025

@NikkiWines
Copy link
Contributor

Caused by #57516

To be resolved by #57856

Discussion

@rayane-d
Copy link
Contributor

rayane-d commented Mar 5, 2025

PR #57856 is merged

@Julesssss
Copy link
Contributor

Fix CP'd awaiting testing

@rayane-d
Copy link
Contributor

rayane-d commented Mar 6, 2025

@Julesssss Could you please check this comment when you get a chance: #57856 (comment)

@Julesssss
Copy link
Contributor

Hmm I get a crash on Android on build 9.1.9-5. I doubt it's related, but don't want to check this off until QA have verified.

@puneetlath puneetlath removed the DeployBlockerCash This issue or pull request should block deployment label Mar 7, 2025
@NikkiWines
Copy link
Contributor

#57856 has been deployed to staging and prod - issue fixed by the original contributor. Closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants