-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-04-03] Report- Report view shakes after returning from Reports & bottom tab moves after saving search #57807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @mollfpr ( |
Triggered auto assignment to @RachCHopkins ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
I can reproduce it, and I see that the RHN panel is shown for a brief moment. I believe this is related to the current implementation of HelpPanel. |
Do you mean RHP? Could you guide me on where this RHN/RHP is displayed? I can't reproduce it 🤔
Currently, I don't see a connection between this bug and the HelpPanel. Could you explain why you think they might be related? |
Yes! I can reproduce bug 1 with a report that has messages. Screen.Recording.2025-03-05.at.23.05.50.mp4For the bug 2, I'm not pretty sure is the new RHP is causing it, but let me try it again. |
Am I doing something wrong? Screen.Recording.2025-03-06.at.15.10.12.mov |
Could you try to zoom in/out the window? Screen.Recording.2025-03-06.at.22.09.42.mp4 |
@mollfpr Still no luck, I can't reproduce on Arc (chromium) |
I can't repro both bugs 1 & 2. Screen.Recording.2025-03-10.at.10.59.33.mp4Asking QA to retest! |
We still can repro 1 bug Recording.3015.mp4 |
@mollfpr, @RachCHopkins Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@mollfpr Eep! 4 days overdue now. Issues have feelings too... |
Any update @blazejkustra? |
Looking into it today, I'll update later 👀 |
I can finally reproduce this! before.mov |
@blazejkustra @mollfpr I am assigned as a reviewer, should I review and test this? |
I have reviewed and tested the PR. |
Thank you @mananjadhav! PR got merged and we can slowly close this issue 😄 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.19-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-04-03. 🎊 For reference, here are some details about the assignees on this issue:
|
@mananjadhav @RachCHopkins @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
BugZero Checklist:
Bug classificationSource of bug:
Where bug was reported:
Who reported the bug:
I don't think we need a regression test on this one. @mollfpr While the issue says not reproducible on Production I was able to, hence I tagged it as production in the checklist. @RachCHopkins This is ready for payout. |
Payment Summary:
No upwork job |
Ready to pay @mananjadhav |
$250 approved for @mananjadhav |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.1.9-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Chat Report View
Action Performed:
Bug 1:
Bug 2:
Expected Result:
Bug 1: Report view will not shake after returning from Reports.
Bug 2: Bottom tab on LHN will not move after saving search.
Actual Result:
Bug 1: Report view shakes after returning from Reports.
Bug 2: Bottom tab on LHN moves after saving search.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6761288_1741130304312.Bug_1.mp4
Bug6761288_1741130286300.Bug_2.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @RachCHopkinsThe text was updated successfully, but these errors were encountered: