Skip to content

[Due for payment 2025-04-03] Report- Report view shakes after returning from Reports & bottom tab moves after saving search #57807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
mitarachim opened this issue Mar 5, 2025 · 33 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@mitarachim
Copy link

mitarachim commented Mar 5, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.9-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Chat Report View

Action Performed:

Bug 1:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit an expense.
  4. Go to Reports.
  5. Go to Inbox.
  6. If the display is wide, page zoom in might be required to reproduce this issue.

Bug 2:

  1. Go to staging.new.expensify.com
  2. Go to Reports.
  3. Click Filters.
  4. Apply filter that will return results.
  5. Click Save search.

Expected Result:

Bug 1: Report view will not shake after returning from Reports.
Bug 2: Bottom tab on LHN will not move after saving search.

Actual Result:

Bug 1: Report view shakes after returning from Reports.
Bug 2: Bottom tab on LHN moves after saving search.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6761288_1741130304312.Bug_1.mp4
Bug6761288_1741130286300.Bug_2.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @RachCHopkins
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Mar 5, 2025
Copy link

melvin-bot bot commented Mar 5, 2025

Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 5, 2025

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Mar 5, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 5, 2025
Copy link
Contributor

github-actions bot commented Mar 5, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mollfpr
Copy link
Contributor

mollfpr commented Mar 5, 2025

I can't reproduce the bug 1.

I can reproduce it, and I see that the RHN panel is shown for a brief moment. I believe this is related to the current implementation of HelpPanel.

@mollfpr mollfpr added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Mar 5, 2025
@blazejkustra
Copy link
Contributor

I see that the RHN panel is shown for a brief moment.

Do you mean RHP? Could you guide me on where this RHN/RHP is displayed? I can't reproduce it 🤔

I believe this is related to the current implementation of HelpPanel.

Currently, I don't see a connection between this bug and the HelpPanel. Could you explain why you think they might be related?

@mollfpr
Copy link
Contributor

mollfpr commented Mar 5, 2025

Do you mean RHP? Could you guide me on where this RHN/RHP is displayed? I can't reproduce it 🤔

Yes! I can reproduce bug 1 with a report that has messages.

Screen.Recording.2025-03-05.at.23.05.50.mp4

For the bug 2, I'm not pretty sure is the new RHP is causing it, but let me try it again.

@blazejkustra
Copy link
Contributor

Yes! I can reproduce bug 1 with a report that has messages.

Am I doing something wrong?

Screen.Recording.2025-03-06.at.15.10.12.mov

@mollfpr
Copy link
Contributor

mollfpr commented Mar 6, 2025

Could you try to zoom in/out the window?

Screen.Recording.2025-03-06.at.22.09.42.mp4

@blazejkustra
Copy link
Contributor

@mollfpr Still no luck, I can't reproduce on Arc (chromium)

@melvin-bot melvin-bot bot added the Overdue label Mar 10, 2025
@mollfpr
Copy link
Contributor

mollfpr commented Mar 10, 2025

I can't repro both bugs 1 & 2.

Screen.Recording.2025-03-10.at.10.59.33.mp4

Asking QA to retest!

@melvin-bot melvin-bot bot removed the Overdue label Mar 10, 2025
@izarutskaya
Copy link

We still can repro 1 bug

Recording.3015.mp4

Copy link

melvin-bot bot commented Mar 13, 2025

@mollfpr, @RachCHopkins Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Mar 21, 2025
Copy link

melvin-bot bot commented Mar 24, 2025

@mollfpr Eep! 4 days overdue now. Issues have feelings too...

@mollfpr
Copy link
Contributor

mollfpr commented Mar 24, 2025

Any update @blazejkustra?

@melvin-bot melvin-bot bot removed the Overdue label Mar 24, 2025
@blazejkustra
Copy link
Contributor

blazejkustra commented Mar 24, 2025

Looking into it today, I'll update later 👀

@blazejkustra
Copy link
Contributor

I can finally reproduce this!

before.mov

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 24, 2025
@blazejkustra
Copy link
Contributor

blazejkustra commented Mar 24, 2025

@mollfpr PR is ready! Thank you for your patience 🙇

@mananjadhav
Copy link
Collaborator

@blazejkustra @mollfpr I am assigned as a reviewer, should I review and test this?

@mananjadhav
Copy link
Collaborator

I have reviewed and tested the PR.

@blazejkustra
Copy link
Contributor

Thank you @mananjadhav! PR got merged and we can slowly close this issue 😄

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 27, 2025
@melvin-bot melvin-bot bot changed the title Report- Report view shakes after returning from Reports & bottom tab moves after saving search [Due for payment 2025-04-03] Report- Report view shakes after returning from Reports & bottom tab moves after saving search Mar 27, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 27, 2025
Copy link

melvin-bot bot commented Mar 27, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Mar 27, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.19-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-03. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Mar 27, 2025

@mananjadhav @RachCHopkins @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@mananjadhav
Copy link
Collaborator

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: Initial implementation of the Side Pane #56490 (comment)

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: NA

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

I don't think we need a regression test on this one. @mollfpr While the issue says not reproducible on Production I was able to, hence I tagged it as production in the checklist.

@RachCHopkins This is ready for payout.

@RachCHopkins
Copy link
Contributor

Payment Summary:

  • Contributor: @blazejkustra no payment due to being a contractor
  • Contributor+: @mananjadhav to be paid $250 via NewDot Manual Requests

No upwork job

@RachCHopkins
Copy link
Contributor

Ready to pay @mananjadhav

@garrettmknight
Copy link
Contributor

$250 approved for @mananjadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants