Skip to content

[Hold for PR #535] [$250] iOS - Wrong cursor placement on the next line when the previous line has a block quote #57290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
IuliiaHerets opened this issue Feb 22, 2025 · 34 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Feb 22, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.4-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Chat Report View

Action Performed:

  1. Launch ND or hybrid app.
  2. Go to chat.
  3. Type the following text

hey

  1. Enter the next line.

Expected Result:

The cursor on the next line will be positioned at the beginning of the line.

Actual Result:

The cursor on the next line is positioned after a few spaces at the beginning of the line.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6750747_1740219132110.ScreenRecording_02-22-2025_18-07-50_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021894347174956898347
  • Upwork Job ID: 1894347174956898347
  • Last Price Increase: 2025-03-04
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 22, 2025
Copy link

melvin-bot bot commented Feb 22, 2025

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@NicMendonca
Copy link
Contributor

@NicMendonca NicMendonca added the External Added to denote the issue can be worked on by a contributor label Feb 25, 2025
@melvin-bot melvin-bot bot changed the title iOS - Wrong cursor placement on the next line when the previous line has a block quote [$250] iOS - Wrong cursor placement on the next line when the previous line has a block quote Feb 25, 2025
Copy link

melvin-bot bot commented Feb 25, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021894347174956898347

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 25, 2025
Copy link

melvin-bot bot commented Feb 25, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

@gurus00
Copy link

gurus00 commented Feb 25, 2025

@getusha I want to work on this issue

@Swor71
Copy link
Contributor

Swor71 commented Mar 4, 2025

Hi, I'm Marcin from Callstack - expert contributor group. I’d like to work on this issue.

@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2025
Copy link

melvin-bot bot commented Mar 4, 2025

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Mar 5, 2025

@getusha 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@getusha
Copy link
Contributor

getusha commented Mar 5, 2025

@NicMendonca we can assign @Swor71 from Callstack

@melvin-bot melvin-bot bot removed the Overdue label Mar 5, 2025
@Swor71
Copy link
Contributor

Swor71 commented Mar 5, 2025

update: digging into the way the live markdown preview parses quote blocks and spacing

Copy link

melvin-bot bot commented Mar 8, 2025

@NicMendonca @getusha this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Mar 8, 2025
Copy link

melvin-bot bot commented Mar 10, 2025

@getusha Eep! 4 days overdue now. Issues have feelings too...

@Swor71
Copy link
Contributor

Swor71 commented Mar 10, 2025

update: this issue should be fixed as part of Expensify/react-native-live-markdown#520 and more precisely this commit however this PR has been open for a while now. I'll check if this fix can be applied sooner.

I have also noticed that the behaviour is different when \n is already present within markdown:

cursor.placement.issue.mov

@melvin-bot melvin-bot bot removed Help Wanted Apply this label when an issue is open to proposals by contributors Overdue labels Mar 10, 2025
@Swor71
Copy link
Contributor

Swor71 commented Mar 11, 2025

update: as per the comment from the pr:

After adding a newline at the end of the blockquote, the typing attributes in the new line still contain NSParagraphStyle with non-zero firstLineHeadIndent and headIntent. This causes the cursor to be shifted to the right instead of being located at the beginning of the line.

I'm currently working on porting and adjusting this fix.

Copy link

melvin-bot bot commented Mar 22, 2025

@NicMendonca @Swor71 @getusha this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@melvin-bot melvin-bot bot added the Overdue label Mar 22, 2025
Copy link

melvin-bot bot commented Mar 25, 2025

@getusha Eep! 4 days overdue now. Issues have feelings too...

@NicMendonca NicMendonca changed the title [Waiting] [$250] iOS - Wrong cursor placement on the next line when the previous line has a block quote [Hold for PR #535] [$250] iOS - Wrong cursor placement on the next line when the previous line has a block quote Mar 25, 2025
@NicMendonca
Copy link
Contributor

NicMendonca commented Mar 25, 2025

Updated title

@NicMendonca
Copy link
Contributor

Holding for this: Expensify/react-native-live-markdown#535

@getusha
Copy link
Contributor

getusha commented Mar 26, 2025

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Mar 26, 2025
@tomekzaw
Copy link
Contributor

Update: still working on this PR since it fixes vertical alignment but breaks other things.

@melvin-bot melvin-bot bot added the Overdue label Mar 31, 2025
Copy link

melvin-bot bot commented Apr 1, 2025

@NicMendonca, @Swor71, @getusha Huh... This is 4 days overdue. Who can take care of this?

@NicMendonca
Copy link
Contributor

Still holding for this: Expensify/react-native-live-markdown#535

@melvin-bot melvin-bot bot removed the Overdue label Apr 1, 2025
@NicMendonca NicMendonca added Weekly KSv2 and removed Daily KSv2 labels Apr 1, 2025
@NicMendonca
Copy link
Contributor

Setting this to weekly - does that make more sense @Swor71 @getusha?

@melvin-bot melvin-bot bot added the Overdue label Apr 10, 2025
@NicMendonca
Copy link
Contributor

Still holding

@melvin-bot melvin-bot bot removed the Overdue label Apr 14, 2025
@melvin-bot melvin-bot bot added the Overdue label Apr 23, 2025
@NicMendonca
Copy link
Contributor

@Swor71 @getusha -- are we still holding?

@melvin-bot melvin-bot bot removed the Overdue label Apr 24, 2025
@melvin-bot melvin-bot bot added the Overdue label May 5, 2025
@NicMendonca
Copy link
Contributor

bump @Swor71 @getusha - I don't see much movement on that PR. Are we still holding for that?

@melvin-bot melvin-bot bot removed the Overdue label May 14, 2025
@melvin-bot melvin-bot bot added the Overdue label May 22, 2025
@NicMendonca
Copy link
Contributor

Okay its been quite a long time. I am going to close and we can revisit this at a later time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

6 participants