Skip to content

iOS Hybrid - Onboarding - Onboarding links show "undefined" #57150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 8 tasks
mitarachim opened this issue Feb 20, 2025 · 11 comments
Closed
1 of 8 tasks

iOS Hybrid - Onboarding - Onboarding links show "undefined" #57150

mitarachim opened this issue Feb 20, 2025 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@mitarachim
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.2-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #57015
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Other

Action Performed:

  1. Launch hybrid app.
  2. Log in with a new Expensifail account.
  3. Create a new workspace.
  4. Go to Concierge chat.
  5. Click any task with link in the description (Create a workspace task).

Expected Result:

Onboarding links are valid and will not show "undefined".

Actual Result:

Onboarding links show "undefined".

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6748611_1740022189356.57015_iOS_-_Test_4.mp4

View all open jobs on GitHub

@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 20, 2025

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 20, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 20, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@jnowakow
Copy link
Contributor

Hello, it's reintroduced by #57015. I'm looking at it again

@trjExpensify
Copy link
Contributor

@jnowakow is that mobile PR ready for review? If so, @robertjchen are you doing that so we can get it merged?

@jnowakow
Copy link
Contributor

@trjExpensify yes, it's here

@trjExpensify
Copy link
Contributor

Perfect, thanks for confirming. Melv didn't assign @robertjchen, so I've done that. 👍

@roryabraham
Copy link
Contributor

@kavimuru
Copy link

Not reproduced

ScreenRecording_02-20-2025.11-41-32_1.MP4

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Feb 20, 2025
@roryabraham roryabraham removed the DeployBlocker Indicates it should block deploying the API label Feb 20, 2025
@robertjchen robertjchen added the Daily KSv2 label Feb 21, 2025
@robertjchen
Copy link
Contributor

Thanks, let's close for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants