-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-02-27] [Due for payment 2025-02-27] Hybrid - Android - Report - App crashes when searching report with from filter if display name has double quote #57088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @abekkala ( |
Triggered auto assignment to @nkuoch ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Hi, I cannot reproduce it both on symulator and physical device. Could you please confirm that it is still reproducible on the latest main? Screen.Recording.2025-02-19.at.12.52.15.mov |
QA team was faced with a similar issue with following repro steps:
Should we export a new issue? screen-20250219-140353.mp4 |
@IuliiaHerets the issue that you mentioned will be fixed in this PR |
It's also possible that even though we cannot reproduce the orginal bug reported in this issue, it will be fixed by the PR above, as this bug might not be linked specifically to double quotes, but to the part where were redirecting to Reports page, which is then crashing because of reanimated bug. |
This is fixed in staging. Assigning @thesahindia for payment since they reviewed the PR #57107 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-02-27. 🎊 For reference, here are some details about the assignees on this issue:
|
@thesahindia @abekkala @thesahindia The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
PAYMENT SUMMARY FOR FEB 27
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.2-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-02-27. 🎊 For reference, here are some details about the assignees on this issue:
|
@thesahindia @abekkala @thesahindia The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Payment Summary
BugZero Checklist (@abekkala)
|
PAYMENT SUMMARY FOR FEB 27
|
@thesahindia can you please complete the checklist? We can then close this out and issue payment. thanks! |
@abekkala Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
We don't need it here. |
PAYMENT SUMMARY
|
$250 approved for @thesahindia |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v9.1.1-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #56869
Issue reported by: Applause Internal Team
Device used: SS S20 FE/ Àndroid 13
App Component: Search
Action Performed:
Precondition: Logged in, A workspace has a member who has Double quotes in his name (e.g: ["" Admin 1802 new])
Expected Result:
Show correct search result
Actual Result:
App crashes
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/29e11162-c2fc-4093-96ab-c4757713990c
Bug6747517_1739947112765!log.txt
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @abekkalaThe text was updated successfully, but these errors were encountered: