Skip to content

[Due for payment 2025-02-27] [Due for payment 2025-02-27] Hybrid - Android - Report - App crashes when searching report with from filter if display name has double quote #57088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 8 tasks
IuliiaHerets opened this issue Feb 19, 2025 · 22 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Feb 19, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.1-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #56869
Issue reported by: Applause Internal Team
Device used: SS S20 FE/ Àndroid 13
App Component: Search

Action Performed:

Precondition: Logged in, A workspace has a member who has Double quotes in his name (e.g: ["" Admin 1802 new])

  1. Open app
  2. Tap on Reports tab
  3. Use suuggestion to finish filter with info: status: all, from "" Admin 1802 new, to: BMA Owner 18023
  4. On keyboard, tap on search icon
  5. Maybe need to repeat step 3+4 2-3 times

Expected Result:

Show correct search result

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/29e11162-c2fc-4093-96ab-c4757713990c
Bug6747517_1739947112765!log.txt

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @abekkala
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Feb 19, 2025
Copy link

melvin-bot bot commented Feb 19, 2025

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 19, 2025

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 19, 2025
Copy link

melvin-bot bot commented Feb 19, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 19, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@289Adam289
Copy link
Contributor

Hi, I cannot reproduce it both on symulator and physical device. Could you please confirm that it is still reproducible on the latest main?

Screen.Recording.2025-02-19.at.12.52.15.mov

@IuliiaHerets
Copy link
Author

QA team was faced with a similar issue with following repro steps:

  1. On Inbox tab, tap on search icon
  2. Type “you” then tap search icon on the keyboard
  3. Tap on Inbox tab again if you are in Reports tab
  4. Repeat step 2+3 for a few more times

Should we export a new issue?

screen-20250219-140353.mp4

@SzymczakJ
Copy link
Contributor

@IuliiaHerets the issue that you mentioned will be fixed in this PR

@SzymczakJ
Copy link
Contributor

It's also possible that even though we cannot reproduce the orginal bug reported in this issue, it will be fixed by the PR above, as this bug might not be linked specifically to double quotes, but to the part where were redirecting to Reports page, which is then crashing because of reanimated bug.
In that case I think we should merge the above PR fast and then retest the whole scenario once again.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Feb 19, 2025
@kavimuru kavimuru unpinned this issue Feb 19, 2025
@luacmartins
Copy link
Contributor

This is fixed in staging. Assigning @thesahindia for payment since they reviewed the PR #57107

@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Feb 20, 2025
@melvin-bot melvin-bot bot changed the title Hybrid - Android - Report - App crashes when searching report with from filter if display name has double quote [Due for payment 2025-02-27] Hybrid - Android - Report - App crashes when searching report with from filter if display name has double quote Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-27. 🎊

For reference, here are some details about the assignees on this issue:

  • @thesahindia requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Feb 20, 2025

@thesahindia @abekkala @thesahindia The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@abekkala
Copy link
Contributor

PAYMENT SUMMARY FOR FEB 27

  • Fix: SWM - no payment needed
  • PR Review: @thesahindia [$250, if no regressions] payment via NewDot
    please complete checklist

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 20, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-02-27] Hybrid - Android - Report - App crashes when searching report with from filter if display name has double quote [Due for payment 2025-02-27] [Due for payment 2025-02-27] Hybrid - Android - Report - App crashes when searching report with from filter if display name has double quote Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.2-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-27. 🎊

For reference, here are some details about the assignees on this issue:

  • @thesahindia requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Feb 20, 2025

@thesahindia @abekkala @thesahindia The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 26, 2025
Copy link

melvin-bot bot commented Feb 27, 2025

Payment Summary

Upwork Job

BugZero Checklist (@abekkala)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@abekkala
Copy link
Contributor

PAYMENT SUMMARY FOR FEB 27

  • Fix: SWM - no payment needed
  • PR Review: @thesahindia [$250, if no regressions] payment via NewDot
    please complete checklist

@abekkala
Copy link
Contributor

@thesahindia can you please complete the checklist? We can then close this out and issue payment. thanks!

@melvin-bot melvin-bot bot added the Overdue label Mar 3, 2025
Copy link

melvin-bot bot commented Mar 4, 2025

@abekkala Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@thesahindia
Copy link
Member

@thesahindia can you please complete the checklist? We can then close this out and issue payment. thanks!

We don't need it here.

@abekkala
Copy link
Contributor

abekkala commented Mar 4, 2025

PAYMENT SUMMARY

@abekkala abekkala closed this as completed Mar 4, 2025
@melvin-bot melvin-bot bot removed Overdue labels Mar 4, 2025
@garrettmknight
Copy link
Contributor

$250 approved for @thesahindia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

8 participants