-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-02-27] [$125] [Navigation] Expense - Currency resets to default currency after returning from confirmation page #56807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @NicMendonca ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @robertjchen ( |
💬 A slack conversation has been started in #expensify-open-source |
This does not feel like a blocker to me as the user can easily complete their task and it works well on the confirmation page |
Job added to Upwork: https://www.upwork.com/jobs/~021889964491189744954 |
Current assignees @shubham1206agra and @dukenv0307 are eligible for the External assigner, not assigning anyone new. |
Current assignee @mountiny is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
@mountiny I found the following issue while testing this bug
Current behavior:Amount page is open Expected behavior:Confirmation page is open Screen.Recording.2025-02-13.at.21.40.05.mov |
@bernhardoj Ah, I think the root cause is about Screen.Recording.2025-02-13.at.21.54.45.mov |
Ah, the goBack works differently now, but even before the navigation refactors, the URL will change if we refresh the confirm page and then go back because the fallback route will be used. I think it's fine for the route So, I think we need to keep initMoneyRequest being called, but don't reset the currency. Lines 655 to 667 in f5cbaf2
|
@dukenv0307 @bernhardoj Yeah, that's the new goBack problem here 😄 The |
Compare params false is already used here. Line 35 in cd3fb6d
|
@NicMendonca, @mountiny, @shubham1206agra, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Will post a summary for SWM with all the issues so they can distrubute them |
Hey, I'm Jakub Szymczak from SWM and I would like to work on this issue. |
📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
@SzymczakJ @mountiny It should be fixed in #56876 |
Linked |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-02-27. 🎊 For reference, here are some details about the assignees on this issue:
|
@dukenv0307 @NicMendonca @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
No regression tests required and no payment required either this came from the big navigation update |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.98-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests
Action Performed:
Precondition:
Expected Result:
Currency will not reset to default currency.
Actual Result:
Currency resets to default currency after returning from confirmation page.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6741373_1739407277724.20250213_083919.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @NicMendoncaThe text was updated successfully, but these errors were encountered: