Skip to content

[HOLD for payment 2025-04-14] [Navigation][HIGH] Chat - User lands on inbox before being redirected to new created chat or group. #56799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 8 tasks
mitarachim opened this issue Feb 13, 2025 · 22 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

mitarachim commented Feb 13, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.98-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome
App Component: Chat Report View

Action Performed:

  1. Open the Expensify app.
  2. Tap on FAB and select "Create Chat"
  3. Add some members to a group chat.
  4. Finish the creation flow.
  5. Check the app´s behaviour when the new chat is created.

Expected Result:

User should be automatically redirected to new individual or group chat after finishing the creation.

Actual Result:

User lands on inbox before being redirected to the new created individual or group chat.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6741316_1739402227074.Create.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @slafortune
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot assigned techievivek and slafortune and unassigned techievivek Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 13, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny
Copy link
Contributor

Let me check this out

@mountiny
Copy link
Contributor

I believe this is an expected behaviiour right now, it is different than before. We can discuss this with @WojtekBoman and @adamgrzybowski

@mountiny mountiny added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 13, 2025
@mountiny mountiny changed the title Chat - User lands on inbox before being redirected to new created chat or group. [Navigation] Chat - User lands on inbox before being redirected to new created chat or group. Feb 13, 2025
@parasharrajat
Copy link
Member

It would be good to directly navigate to the group chat.

@adamgrzybowski
Copy link
Contributor

@WojtekBoman
Copy link
Contributor

Hey, I'm going to work on that :)

@mountiny
Copy link
Contributor

Making this weekly, its not that urgent and Wojtek will be ooo

@melvin-bot melvin-bot bot added the Overdue label Mar 2, 2025
@WojtekBoman
Copy link
Contributor

I'm working on it!

@melvin-bot melvin-bot bot removed the Overdue label Mar 5, 2025
@WojtekBoman
Copy link
Contributor

Hey, to fix this issue I need changes from this PR, I'll raise a PR for this issue once the PR I mentioned is merged

@slafortune
Copy link
Contributor

@WojtekBoman looks like you're good to go now 👍

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Mar 12, 2025
@mallenexpensify mallenexpensify moved this from MEDIUM to HIGH in [#whatsnext] #quality Mar 12, 2025
@mallenexpensify mallenexpensify changed the title [Navigation] Chat - User lands on inbox before being redirected to new created chat or group. [Navigation][HIGH] Chat - User lands on inbox before being redirected to new created chat or group. Mar 12, 2025
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Apr 14, 2025
Copy link

melvin-bot bot commented Apr 14, 2025

This issue has not been updated in over 15 days. @slafortune, @mountiny, @WojtekBoman, @ZhenjaHorbach eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Apr 14, 2025
@mountiny
Copy link
Contributor

@WojtekBoman This was resolved right and we can close?

@WojtekBoman
Copy link
Contributor

Yes, I see the PR for that has been merged

@mountiny mountiny added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review Monthly KSv2 labels Apr 14, 2025
@mountiny mountiny changed the title [Navigation][HIGH] Chat - User lands on inbox before being redirected to new created chat or group. [HOLD for payment 2025-04-14] [Navigation][HIGH] Chat - User lands on inbox before being redirected to new created chat or group. Apr 14, 2025
@mountiny
Copy link
Contributor

@slafortune I think we just need to pay $250 to @ZhenjaHorbach now

No new regression tests are required for this imho

@ZhenjaHorbach can you complete the checklist please?

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Apr 14, 2025

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Unfortunately, I did not find a suitable PR.

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: NA

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Test:

  1. Open App
  2. Tap on FAB and select "Create Chat"
  3. Add some members to a group chat.
  4. Finish the creation flow.
  5. Verify that an user should be automatically redirected to new individual or group chat after finishing the creation

Do we agree 👍 or 👎

@slafortune
Copy link
Contributor

slafortune commented Apr 14, 2025

@melvin-bot melvin-bot bot added the Overdue label Apr 17, 2025
@slafortune
Copy link
Contributor

@ZhenjaHorbach Paid ✅

@melvin-bot melvin-bot bot removed the Overdue label Apr 17, 2025
@github-project-automation github-project-automation bot moved this from HIGH to Done in [#whatsnext] #quality Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
Status: Done
Development

No branches or pull requests

8 participants