Skip to content

[HOLD on payment] [$250] PR56048-Invoice-The text in the title field in Details and the editable field don't match #56508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 8 tasks
mitarachim opened this issue Feb 7, 2025 · 40 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@mitarachim
Copy link

mitarachim commented Feb 7, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.95-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #56048
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Windows 10/ Chrome, Samsung S23FE/ Android 14
App Component: Money Requests

Action Performed:

Precondition: Have a workspace created with invoice feature enabled.

  1. Go to https://staging.new.expensify.com/
  2. Send an invoice
  3. Open the invoice created
  4. Open the invoice header
  5. Click on the Title field

Expected Result:

The text in the title field in Details and the editable field matches.

Actual Result:

The text in the title field in Details and the editable field don't match.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6735791_1738892948993.Unmatch_texts.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021889071920301448517
  • Upwork Job ID: 1889071920301448517
  • Last Price Increase: 2025-02-10
  • Automatic offers:
    • shubham1206agra | Contributor | 106073218
Issue OwnerCurrent Issue Owner: @shubham1206agra
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Feb 7, 2025
Copy link

melvin-bot bot commented Feb 7, 2025

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 7, 2025

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 7, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@NJ-2020
Copy link
Contributor

NJ-2020 commented Feb 8, 2025

Seems like coming from this PR: #50135

@mallenexpensify
Copy link
Contributor

@zfurtak @DylanDylann , 👀 plz, to see if #50135 is the offending PR. Thanks @NJ-2020 for commenting.

@zfurtak
Copy link
Contributor

zfurtak commented Feb 10, 2025

I will look into it

@zfurtak
Copy link
Contributor

zfurtak commented Feb 10, 2025

I'll be out of office this week, but I can take care of this issue on Monday.

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Feb 10, 2025
@melvin-bot melvin-bot bot changed the title PR56048-Invoice-The text in the title field in Details and the editable field don't match [$250] PR56048-Invoice-The text in the title field in Details and the editable field don't match Feb 10, 2025
Copy link

melvin-bot bot commented Feb 10, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021889071920301448517

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 10, 2025
Copy link

melvin-bot bot commented Feb 10, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

@luacmartins
Copy link
Contributor

This actually comes from #56048. It seems like we want to use the ... owes pattern in ND, but once we click into the menu item, the populated name is the OD one.

@luacmartins
Copy link
Contributor

Demoting and assigning it to the original authors

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Feb 10, 2025
@mallenexpensify mallenexpensify added Weekly KSv2 and removed Daily KSv2 labels Feb 28, 2025
@mallenexpensify mallenexpensify changed the title [Due for payment 2025-02-25] [$250] PR56048-Invoice-The text in the title field in Details and the editable field don't match [HOLD on payment] [$250] PR56048-Invoice-The text in the title field in Details and the editable field don't match Feb 28, 2025
@mallenexpensify
Copy link
Contributor

mallenexpensify commented Feb 28, 2025

Holding for a min for payment, per @shubham1206agra 's request. Made it a weekly and made you issue owner @shubham1206agra , updated title too.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Mar 24, 2025
Copy link

melvin-bot bot commented Mar 24, 2025

This issue has not been updated in over 15 days. @cristipaval, @luacmartins, @mallenexpensify, @rezkiy37, @shubham1206agra eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mallenexpensify
Copy link
Contributor

@shubham1206agra any update here?

@mallenexpensify mallenexpensify removed their assignment Mar 28, 2025
@mallenexpensify mallenexpensify added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Mar 28, 2025
Copy link

melvin-bot bot commented Mar 28, 2025

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Mar 28, 2025
@mallenexpensify
Copy link
Contributor

@VictoriaExpensify I'm going to be OOO and offline for two weeks so I'm reassigning, will pick back up upon my return, thx

We're waiting for @shubham1206agra to tell us when we can pay.

@mallenexpensify mallenexpensify self-assigned this Mar 28, 2025
Copy link

melvin-bot bot commented Apr 1, 2025

@shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2025
@VictoriaExpensify
Copy link
Contributor

Hey @shubham1206agra - any update?

@melvin-bot melvin-bot bot removed the Overdue label Apr 3, 2025
@shubham1206agra
Copy link
Contributor

@VictoriaExpensify You can issue payment here

Copy link

melvin-bot bot commented Apr 8, 2025

@shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Apr 8, 2025
Copy link

melvin-bot bot commented Apr 10, 2025

@shubham1206agra Still overdue 6 days?! Let's take care of this!

@shubham1206agra
Copy link
Contributor

Waiting for payment

@melvin-bot melvin-bot bot removed the Overdue label Apr 12, 2025
@mallenexpensify
Copy link
Contributor

Contributor+: @shubham1206agra due $250 via NewDot!

@garrettmknight
Copy link
Contributor

$250 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests