Skip to content

VBA flow - Error message for very old birth date is not inline instead appears at the bottom of the page #5645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kavimuru opened this issue Oct 5, 2021 · 7 comments
Assignees

Comments

@kavimuru
Copy link

kavimuru commented Oct 5, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue was found when executing #5615

Action Performed:

  1. Go to https://staging.new.expensify.com
  2. Log in with expensifail account
  3. Navigate to https://staging.new.expensify.com/bank-account/personal-information
  4. Put on the Identity form, enter a very old birth date

Expected Result:

Inline error message appears for the very old birth date like younger birth date

Actual Result:

Error message appears for the very old birth date appears at the bottom of the page.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.5-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5265679_error

Bug5265679_Recording__428.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@madmax330
Copy link
Contributor

@marcaaron would this be part of the N6 polish?

@flodnv
Copy link
Contributor

flodnv commented Oct 5, 2021

Explained here, let's check again after @deetergp has deployed web-secure.

@flodnv flodnv self-assigned this Oct 5, 2021
@marcaaron
Copy link
Contributor

That error is thrown in the backend so no, we shouldn't handle it inline.
But AFAIK we added front end validation for it I believe in this PR which hit staging yesterday.
Maybe it's not working? cc @aldo-expensify

@aldo-expensify
Copy link
Contributor

Hmm, we now have front end validations to restrict the age between 150 and 18 years old. The date of birth 1890-01-01 gives you an age within range (~130), so it doesn't trigger the new front end age requirement validations.

I tested on staging using that exact date of birth (1890-01-01) in the "Personal information" step, and I doesn't give me any error, I can continue just fine.

Also, the date format looks different in my case, could this have happen in an older version of NewDot?

How it looks now:
Screen Shot 2021-10-05 at 3 24 26 PM

@isagoico
Copy link

isagoico commented Oct 5, 2021

So weird, we were not able to continue yesterday using the 01-01-1890 date
image

I went ahead and tested with over the ~150 years and got this error of not being over 18 years old 🤔
image

CC @chirag

@flodnv
Copy link
Contributor

flodnv commented Oct 6, 2021

Closing in favor of the other open issue

@flodnv flodnv closed this as completed Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants