[$250] Distance Rates - Disabling rate toggle triggers a brief on-off action after relogging

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue was found while executing QA for PR #55192

Version Number: 9.0.93-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #55192
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: android
App Component: Workspace Settings

Action Performed:

1. Open the app and log in
2. Create a Workspace
3. Enable Distance Rates
4. Add a new rate
5. Disable the rate added in step 4

Expected Result:

When disabling a rate it should remain off

Actual Result:

Disabling the toggle in Distance Rates triggers a brief on-off action the first time after relogging.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[vincdargento]

@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[JmillsExpensify]

Looks right to me.

[roryabraham]

ok, let me see if I can figure out how to build Android HybridApp

[roryabraham]

Got Android built, now having to rebuild the back-end bits

[roryabraham]

Still just wrestling with my dev env, but making progress

[roryabraham]

Finally was able to reproduce locally

[roryabraham]

One thing I notice is that it only happens if you disable the rate right after adding it. If you wait a few moments before disabling it, the issue doesn't occur

[roryabraham]

Using logs, I see that this is the value that's toggling in error

[roryabraham]

Looking into this, I'm going to demote it for a few reasons:

• It's inconsistently reproducible
• You have to disable the distance rate soon after adding it (edge case for sure)
• The end state is correct

[s77rt]

Regarding inconsistency: this seems to occur only if OpenPolicyDistanceRatesPage (read) is queued before SetPolicyDistanceRatesEnabled (write)

Screen.Recording.2025-02-03.at.11.53.15.PM.mov

[abzokhattab]

i am not able to reproduce it

Screen.Recording.2025-02-04.at.00.05.36.mov

[abzokhattab]

@s77rt how should we avoid this queueing inconsistency?

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[JmillsExpensify]

Potentially not reproducible anymore

[melvin-bot]

@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@JmillsExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@JmillsExpensify Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@JmillsExpensify 10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

@JmillsExpensify 12 days overdue now... This issue's end is nigh!

[s77rt]

@JmillsExpensify Can you edit the OP manually and change the issue owner?

[JmillsExpensify]

Sorry someone else will need to change the issue owner. Shall I increase the payout to $500 so we can get more proposals?

[s77rt]

@JmillsExpensify I think $250 is still fine but we should update the title so the price is reflected. @roryabraham Can you please do that and also make me the issue owner. Thanks!

[mvtglobally]

Issue not reproducible during KI retests. (Third week)

[s77rt]

I can't reproduce this in normal flow, the only time I was able to reproduce is by using the "slow network" testing feature which itself could be the problem. Testing with chrome slow 4g and 3g presets works fine. Let's close and reopen if this is reported again

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[JmillsExpensify]

Based on the latest comments, here's the payment summary:

• Contributor: @abzokhattab $250 via Upwork
• Reviewer: @s77rt $250 via New Expensify

[JmillsExpensify]

Upwork offer sent.

[melvin-bot]

@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

Contributor paid out. @s77rt please request via New Expensify if you haven't already.

[garrettmknight]

Payment summary:

• Contributor: @abzokhattab $250 via Upwork
• Reviewer: @s77rt $250 via New Expensify

[JmillsExpensify]

$250 approved for @s77rt